[Rt-commit] rt branch, 4.2/queue-watcher-valid-type, created. rt-4.2.5-65-g5eeec0e

[Alex Vandiver]

The branch, 4.2/queue-watcher-valid-type has been created
        at  5eeec0e28289f9d08fcdf86f5f7fa044b1442e79 (commit)

- Log -----------------------------------------------------------------
commit 5eeec0e28289f9d08fcdf86f5f7fa044b1442e79
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jun 26 15:51:46 2014 -0400

    Ensure that IsManageableRoleGroupType only returns true for valid roles
    
    IsManageableRoleGroupType was only checking that the role group was not
    an ACL-only group -- not that it was also a valid group at all.  This
    caused the queue watcher page to report "No valid Type specified" for
    every user search result that was left blank.
    
    Fixes: #29993

diff --git a/lib/RT/Queue.pm b/lib/RT/Queue.pm
index 8ed820c..ba0d7e4 100644
--- a/lib/RT/Queue.pm
+++ b/lib/RT/Queue.pm
@@ -561,7 +561,7 @@ Returns whether the passed-in type is a manageable role group type.
 sub IsManageableRoleGroupType {
     my $self = shift;
     my $type = shift;
-    return not $self->Role($type)->{ACLOnly};
+    return $self->HasRole($type) and not $self->Role($type)->{ACLOnly};
 }
 
 

-----------------------------------------------------------------------