[Rt-commit] rt branch, 4.4/remove-SetFieldsOnce, created. rt-4.2.3-23-gfff02b8

[Kevin Falcone]

The branch, 4.4/remove-SetFieldsOnce has been created
        at  fff02b8be922cef5306f904a7dd5a307a0759ed1 (commit)

- Log -----------------------------------------------------------------
commit fff02b8be922cef5306f904a7dd5a307a0759ed1
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Mar 7 16:12:44 2014 -0500

    Remove SetFieldsOnce
    
    This callback was added in d77874ed to allow you to munge the %once
    declared @fields variable.  If you used Default, you would keep
    appending to the global shared variable.  When c07d62ad fixed the bug
    that we were pushing Custom Fields onto the global shared variable by
    switching from a %once to an %init, this callback became useless because
    @fields was redeclared on every request.
    
    The first commit was in 3.7.15, the second was in 3.7.86.  This means no
    released version of RT has had a version of this callback which worked
    properly.  Remove it to avoid severe confusion.
    
    The correct solution is to use the Default callback.
    
    CallbackOnce is still used properly with %once blocks in ColumnMap.

diff --git a/share/html/Search/Elements/BuildFormatString b/share/html/Search/Elements/BuildFormatString
index 66362fb..b150a4d 100644
--- a/share/html/Search/Elements/BuildFormatString
+++ b/share/html/Search/Elements/BuildFormatString
@@ -99,8 +99,6 @@ my @fields = qw(
     NBSP
 ); # loc_qw
 
-$m->callback( CallbackOnce => 1, CallbackName => 'SetFieldsOnce', Fields => \@fields );
-
 my $CustomFields = RT::CustomFields->new( $session{'CurrentUser'});
 foreach my $id (keys %queues) {
     # Gotta load up the $queue object, since queues get stored by name now.

-----------------------------------------------------------------------