[Rt-commit] rt branch, 4.2-trunk, updated. rt-4.2.3-41-g665c355

Alex Vandiver alexmv at bestpractical.com
Thu Mar 20 11:23:22 EDT 2014


The branch, 4.2-trunk has been updated
       via  665c35588d2f24a84af61535ab6cabf20e903a93 (commit)
      from  6207b1a662b31d31104577c0162e251439565114 (commit)

Summary of changes:
 etc/RT_Config.pm.in | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

- Log -----------------------------------------------------------------
commit 665c35588d2f24a84af61535ab6cabf20e903a93
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Mar 20 10:39:13 2014 -0400

    Remove ambiguity of "substitute ... for ..." in $CanonicalizeEmailAddressMatch
    
    The phrase "substitute x for y" can be read to either mean "substitute
    occurrences of x for y" (leaving y in the finished string) or
    "substitute x for occurrences of y" (leaving x in the finished string).
    Reword to use less ambiguous phrasing, and link more explicitly to to
    CanonicalizeEmailAddress for overriding, in case of more complex
    canonicalization.

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index abdfe0c..8ebb13b 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -424,13 +424,13 @@ Set($RTAddressRegexp, undef);
 =item C<$CanonicalizeEmailAddressMatch>, C<$CanonicalizeEmailAddressReplace>
 
 RT provides functionality which allows the system to rewrite incoming
-email addresses.  In its simplest form, you can substitute the value
-in C<CanonicalizeEmailAddressMatch> for the value in
-C<CanonicalizeEmailAddressReplace> (These values are passed to the
-C<CanonicalizeEmailAddress> subroutine in F<RT/User.pm>)
-
-By default, that routine performs a C<s/$Match/$Replace/gi> on any
-address passed to it.
+email addresses, using L<RT::User/CanonicalizeEmailAddress>.  The
+default implementation replaces all occurrences of the regular
+expression in C<CanonicalizeEmailAddressMatch> with
+C<CanonicalizeEmailAddressReplace>, via C<s/$Match/$Replace/gi>.  The
+most common use of this is to replace C<@something.example.com> with
+C<@example.com>.  If more complex noramlization is required,
+L<RT::User/CanonicalizeEmailAddress> can be overridden to provide it.
 
 =cut
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list