[Rt-commit] rt branch, 4.2/cron-template-caching, repushed
Alex Vandiver
alexmv at bestpractical.com
Tue May 6 21:24:42 EDT 2014
The branch 4.2/cron-template-caching was deleted and repushed:
was 293f24e178a00602d282a3d6f88e7a53ec0592b2
now ec268318f431486187af0a0d9f43b76408505014
1: 293f24e ! 1: ec26831 Remove caching of template objects in rt-cronjob
@@ -9,12 +9,12 @@
RT::Action::SendEmail->Prepare calls ->Parse, which clears out its
->MIMEObj.
- Unfortunately, a1a4f73e Template objects which already had a MIMEObj to
- retain them. In the context of rt-cronjob, this causes the same content
- (that formed from the first mathcing ticket) to be sent out on all
- tickets whenever RT::Action::SendEmail is used as the target action.
- RT::Action::RecordCorrespondence is unaffected, however, as it always
- calls ->Parse.
+ Unfortunately, a1a4f73e caused Template objects which already had a
+ MIMEObj to retain them. In the context of rt-cronjob, this causes the
+ same content (that formed from the first matching ticket) to be sent out
+ on all tickets whenever RT::Action::SendEmail is used as the target
+ action. RT::Action::RecordCorrespondence is unaffected, however, as it
+ always calls ->Parse.
Remove the unnecessary cache in rt-conjob; looking up a Template objects
per RT::Ticket result is unlikely to result in performance implications,
More information about the rt-commit
mailing list