[Rt-commit] rt branch, 4.2/charts-upgrade-content, created. rt-4.2.4-15-gefabca5

[Wallace Reis]

The branch, 4.2/charts-upgrade-content has been created
        at  efabca5f82b7d8b8e1c194d89da40d283111af83 (commit)

- Log -----------------------------------------------------------------
commit efabca5f82b7d8b8e1c194d89da40d283111af83
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Sat Apr 26 15:19:10 2014 -0300

    I#29595: Undef foolproof for PrimaryGroupBy on upgrade
    
    In 4.0, when we process the submitted form for save chart operation
    without changing any option in the dropdowns (either ChartStyle or
    PrimaryGroupBy), then there isn't any value in the %ARGS which causes
    these options to be saved as undef in DB. Additionally, that is the
    same behavior for 4.2. Thus, we need to undef foolproof when handling
    PrimaryGroupBy to avoid the warnings.

diff --git a/etc/upgrade/4.1.17/content b/etc/upgrade/4.1.17/content
index 3454f78..2e6a78c 100644
--- a/etc/upgrade/4.1.17/content
+++ b/etc/upgrade/4.1.17/content
@@ -15,7 +15,7 @@ our @Initial = (sub {
         # Switch from "CreatedMonthly" to "Created.Monthly"
         $content->{GroupBy} ||= [delete $content->{PrimaryGroupBy}];
         for (@{$content->{GroupBy}}) {
-            next if /\./;
+            next if !defined || /\./;
             s/(?<=[a-z])(?=[A-Z])/./;
         }
 

-----------------------------------------------------------------------