[Rt-commit] rt branch, 4.2/shredder-critic, repushed

[Alex Vandiver]

The branch 4.2/shredder-critic was deleted and repushed:
       was a6dff987c47ba2cda1257042b8e38e78440af708
       now 1c2d400cc11c9b3e836c383f62aa445892abd5a1

1:  b2cbc2b < -:  ------- sort is undefined in scalar context
2:  180dd02 = 1:  da723e0 use foreach to edit array, not map
3:  0a8e675 < -:  ------- eval_require util function that does eval "require $class"
4:  e8a349f < -:  ------- use eval_require
-:  ------- > 2:  c88790c Switch to using UNIVERSAL::require rather than eval "require $_"
5:  ce91c2c ! 3:  5459e25 More all code after package definition
    @@ -1,6 +1,6 @@
     Author: Ruslan Zakirov <ruz at bestpractical.com>
     
    -    use warnings, run code after package definition
    +    More all code after package definition
     
     diff --git a/lib/RT/Shredder/ACE.pm b/lib/RT/Shredder/ACE.pm
     --- a/lib/RT/Shredder/ACE.pm
    @@ -9,9 +9,9 @@
      #
      # END BPS TAGGED BLOCK }}}
      
    --use RT::ACE qw();
    +-use RT::ACE ();
      package RT::ACE;
    -+use RT::ACE qw();
    ++use RT::ACE ();
      
      use strict;
      use warnings;
    @@ -72,32 +72,6 @@
      use strict;
      use warnings;
     
    -diff --git a/lib/RT/Shredder/Dependencies.pm b/lib/RT/Shredder/Dependencies.pm
    ---- a/lib/RT/Shredder/Dependencies.pm
    -+++ b/lib/RT/Shredder/Dependencies.pm
    -@@
    - package RT::Shredder::Dependencies;
    - 
    - use strict;
    -+use warnings;
    -+
    - use RT::Shredder::Exceptions;
    - use RT::Shredder::Constants;
    - use RT::Shredder::Dependency;
    -
    -diff --git a/lib/RT/Shredder/Dependency.pm b/lib/RT/Shredder/Dependency.pm
    ---- a/lib/RT/Shredder/Dependency.pm
    -+++ b/lib/RT/Shredder/Dependency.pm
    -@@
    - package RT::Shredder::Dependency;
    - 
    - use strict;
    -+use warnings;
    -+
    - use RT::Shredder::Constants;
    - use RT::Shredder::Exceptions;
    - 
    -
     diff --git a/lib/RT/Shredder/Group.pm b/lib/RT/Shredder/Group.pm
     --- a/lib/RT/Shredder/Group.pm
     +++ b/lib/RT/Shredder/Group.pm
6:  177ee05 ! 4:  d6ebf9f decriticize shredder's code
    @@ -32,29 +32,21 @@
      
      =head4 CastObjectsToRecords( Objects => undef )
     @@
    -         next if $v->{'State'} & (WIPED | IN_WIPING);
    -         $self->Wipeout( Object => $v->{'Object'} );
    +         next if $cache_val->{'State'} & (WIPED | IN_WIPING);
    +         $self->Wipeout( Object => $cache_val->{'Object'} );
          }
     +    return;
      }
      
      sub Wipeout
     @@
    -         die $@ if RT::Shredder::Exception::Info->caught;
    -         die "Couldn't wipeout object: $@";
    +         die $error if RT::Shredder::Exception::Info->caught;
    +         die "Couldn't wipeout object: $error";
          }
     +    return;
      }
      
      sub _Wipeout
    -@@
    -         next if( $record->{'State'} & VALID );
    -         $record->{'Object'}->ValidateRelations( Shredder => $self );
    -     }
    -+    return;
    - }
    - 
    - =head3 Data storage and backups
     @@
              my ($state, $msg) = $_->Run( %args );
              die "Couldn't run plugin: $msg" unless $state;
7:  a6dff98 ! 5:  16c23fd update perl critic policies
    @@ -29,3 +29,4 @@
     +
     +[BuiltinFunctions::RequireBlockMap]
     +severity = 1
    +
-:  ------- > 6:  1c2d400 Remove skip_all from dependency checks which are in developer deps