[Rt-commit] rt branch, 4.2/confirm-loaded-queue, repushed

[Alex Vandiver]

The branch 4.2/confirm-loaded-queue was deleted and repushed:
       was b30020aa119ef32131c4c80e2109a30720cc8f79
       now 487df4d92f0dcc6fd197e60b99719fcbe979cbcc

 1:  2c714ae =  1:  57e10bf Confirm loaded queue object before setting context object
 2:  1e4bab3 !  2:  7473e98 Explicitly exclude 0 from queue lookup
    @@ -4,7 +4,7 @@
         
         A Queue value of 0 represents a global CF, but will not load a
         queue successfully. Explicitly exclude 0 from the queue load and
    -    context object setting. Although 2c714ae3 will now prevent this,
    +    context object setting. Although 57e10bf9 will now prevent this,
         it logs a warning that is inappropriate when using the documented
         API for the method.
     
 3:  a38b879 =  3:  f6eecac Tests for LoadByName with queue 0
 4:  20f9139 =  4:  00f9f24 These statements simplify to "skip if the queue is undef or 0"
 5:  7463ce8 =  5:  d68734f Short-circuit if a bogus Queue was passed
 6:  c5e4da6 !  6:  f1c5aeb Simplify logic by loading the queue even if not strictly necessary
    @@ -2,7 +2,7 @@
     
         Simplify logic by loading the queue even if not strictly necessary
         
    -    The existing logic i nthe "if" statement serves to skip the block in
    +    The existing logic in the "if" statement serves to skip the block in
         precisely one situation -- the passed Queue is numeric, and there
         already exists a ContextObject.  In such situation, it is not necessary
         to attempt to load the Queue -- but it is not harmful, either.  In fact,
 7:  4daccd2 !  7:  25ccf89 Move LookupType defaulting earlier
    @@ -1,6 +1,9 @@
     Author: Alex Vandiver <alexmv at bestpractical.com>
     
         Move LookupType defaulting earlier
    +    
    +    We will use the LookupType as a default in the next commit, and thus
    +    need to have it prior to when we resolve the object (currently Queue).
     
     diff --git a/lib/RT/CustomField.pm b/lib/RT/CustomField.pm
     --- a/lib/RT/CustomField.pm
 8:  bba5d67 =  8:  7d7ab57 Allow for non-Queue context objects
 9:  3dce690 =  9:  3165021 Allow callers to not get disabled CFs
10:  3788025 = 10:  51d22fd Allow callers to look in Queue and global CFs
11:  f01afb8 = 11:  5ea0b2e Optimize the query slightly, by eliminating an unnecessary DISTINCT
12:  9045cdd = 12:  2b181e4 Document but deprecate the old names for LoadByName
13:  4607681 = 13:  f4db1cc Add tests for the new LoadByName functionality
14:  b30020a = 14:  487df4d Switch existing code to using LookupType with LoadByName, to be explicit