[Rt-commit] rt branch, 4.4/drop-ticket-disabled-column, created. rt-4.2.5-210-g3dbbeca

? sunnavy sunnavy at bestpractical.com
Mon Nov 17 21:18:27 EST 2014


The branch, 4.4/drop-ticket-disabled-column has been created
        at  3dbbeca7ba5ff177868848089e41aac3c7ba151a (commit)

- Log -----------------------------------------------------------------
commit 3dbbeca7ba5ff177868848089e41aac3c7ba151a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Oct 23 22:53:02 2014 +0800

    drop Disabled column in Tickets
    
    it's not been used for a long long while
    
    Fixes: #30430

diff --git a/etc/schema.Oracle b/etc/schema.Oracle
index 847adfa..2a0849b 100755
--- a/etc/schema.Oracle
+++ b/etc/schema.Oracle
@@ -279,8 +279,7 @@ CREATE TABLE Tickets (
         LastUpdatedBy           NUMBER(11,0) DEFAULT 0 NOT NULL,
         LastUpdated             DATE,
         Creator                 NUMBER(11,0) DEFAULT 0 NOT NULL,
-        Created                 DATE,
-        Disabled                NUMBER(11,0) DEFAULT 0 NOT NULL
+        Created                 DATE
 );
 CREATE INDEX Tickets1 ON Tickets (Queue, Status);
 CREATE INDEX Tickets2 ON Tickets (Owner);
diff --git a/etc/schema.Pg b/etc/schema.Pg
index c1ef22f..dbe23a3 100755
--- a/etc/schema.Pg
+++ b/etc/schema.Pg
@@ -435,7 +435,6 @@ CREATE TABLE Tickets (
   LastUpdated TIMESTAMP NULL  ,
   Creator integer NOT NULL DEFAULT 0  ,
   Created TIMESTAMP NULL  ,
-  Disabled integer NOT NULL DEFAULT 0 ,
   PRIMARY KEY (id)
 
 );
diff --git a/etc/schema.SQLite b/etc/schema.SQLite
index b748d85..80e5749 100755
--- a/etc/schema.SQLite
+++ b/etc/schema.SQLite
@@ -311,9 +311,7 @@ CREATE TABLE Tickets (
   LastUpdatedBy integer NULL DEFAULT 0 ,
   LastUpdated DATETIME NULL  ,
   Creator integer NULL DEFAULT 0 ,
-  Created DATETIME NULL  ,
-  Disabled int2 NOT NULL DEFAULT 0
-  
+  Created DATETIME NULL
 ) ;
 
 CREATE INDEX Tickets1 ON Tickets (Queue, Status) ;
diff --git a/etc/schema.mysql b/etc/schema.mysql
index f1458b4..f69ea4c 100755
--- a/etc/schema.mysql
+++ b/etc/schema.mysql
@@ -293,7 +293,6 @@ CREATE TABLE Tickets (
   LastUpdated DATETIME NULL  ,
   Creator integer NOT NULL DEFAULT 0  ,
   Created DATETIME NULL  ,
-  Disabled int2 NOT NULL DEFAULT 0 ,
   PRIMARY KEY (id)
 ) ENGINE=InnoDB CHARACTER SET utf8;
 
diff --git a/etc/upgrade/4.3.5/schema.Oracle b/etc/upgrade/4.3.5/schema.Oracle
new file mode 100644
index 0000000..cf01202
--- /dev/null
+++ b/etc/upgrade/4.3.5/schema.Oracle
@@ -0,0 +1 @@
+ALTER TABLE Tickets DROP COLUMN Disabled;
diff --git a/etc/upgrade/4.3.5/schema.Pg b/etc/upgrade/4.3.5/schema.Pg
new file mode 100644
index 0000000..cf01202
--- /dev/null
+++ b/etc/upgrade/4.3.5/schema.Pg
@@ -0,0 +1 @@
+ALTER TABLE Tickets DROP COLUMN Disabled;
diff --git a/etc/upgrade/4.3.5/schema.mysql b/etc/upgrade/4.3.5/schema.mysql
new file mode 100644
index 0000000..cf01202
--- /dev/null
+++ b/etc/upgrade/4.3.5/schema.mysql
@@ -0,0 +1 @@
+ALTER TABLE Tickets DROP COLUMN Disabled;
diff --git a/lib/RT/Ticket.pm b/lib/RT/Ticket.pm
index 95d3042..69d0953 100644
--- a/lib/RT/Ticket.pm
+++ b/lib/RT/Ticket.pm
@@ -3428,26 +3428,6 @@ Returns the current value of Created.
 
 =cut
 
-
-=head2 Disabled
-
-Returns the current value of Disabled.
-(In the database, Disabled is stored as smallint(6).)
-
-
-
-=head2 SetDisabled VALUE
-
-
-Set Disabled to VALUE.
-Returns (1, 'Status message') on success and (0, 'Error Message') on failure.
-(In the database, Disabled will be stored as a smallint(6).)
-
-
-=cut
-
-
-
 sub _CoreAccessible {
     {
 
@@ -3501,9 +3481,6 @@ sub _CoreAccessible {
                 {read => 1, auto => 1, sql_type => 4, length => 11,  is_blob => 0,  is_numeric => 1,  type => 'int(11)', default => '0'},
         Created =>
                 {read => 1, auto => 1, sql_type => 11, length => 0,  is_blob => 0,  is_numeric => 0,  type => 'datetime', default => ''},
-        Disabled =>
-                {read => 1, write => 1, sql_type => 5, length => 6,  is_blob => 0,  is_numeric => 1,  type => 'smallint(6)', default => '0'},
-
  }
 };
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list