[Rt-commit] rt branch, 4.2/fts-refactor-performance, repushed

[Alex Vandiver]

The branch 4.2/fts-refactor-performance was deleted and repushed:
       was 1a692869844af61c6d9f14f04d87c3b643e7060c
       now b36617027c1d88a612043f904db9e24ac3faae25

 1:  a7968ec =  1:  a7968ec Add full path to one rt-fulltext-indexer that lacks it
 2:  84747c7 =  2:  84747c7 Add additional clarification points about Sphinx on MySQL
 3:  ac688e2 =  3:  ac688e2 Drop sphinx xmlpipe2 output, which was unusable and undocumented
 4:  d5f256f =  4:  d5f256f Drop finalize and clean functions, which are now unused
 5:  02a8588 =  5:  02a8588 Rename Sphinx FTS search tests to "sphinx", not "mysql"
 6:  84066c4 =  6:  84066c4 Support native FTS on MySQL 5.6 and above
 7:  77641fc =  7:  77641fc Using a separate MyISAM table, we can also support FTS on MySQL < 5.6
 8:  355b60c =  8:  355b60c extract_text and extract_html are identical; inline them
 9:  aebf2c1 =  9:  aebf2c1 Inline the differences between text/plain and text/html attachment lists
10:  2b3d5df = 10:  2b3d5df Stop skipping indexing of text/html within multipart/alternative
11:  262ab27 = 11:  262ab27 Use the new, shorter, initialization form
12:  864f449 = 12:  864f449 Simplify and condense option parsing
13:  05b3246 = 13:  05b3246 Documentation has moved out; update --help accordingly
14:  81fa26d = 14:  81fa26d Remove AUTHOR section; it is unnecessary in core sbin files
15:  06089a2 = 15:  06089a2 Skipping ACL checks yields a sizable performance increase
16:  e722688 = 16:  e722688 Index attachments in one pass through the database, not two
17:  eba441b = 17:  eba441b Index attachments even on deleted tickets
18:  bcd4e6b = 18:  bcd4e6b mysql and pg share the same last_indexed; unify the method
19:  41420bf = 19:  41420bf Replace the last use of goto_specific with explicit function calls
20:  d23df4e = 20:  d23df4e Simplify last_indexed
21:  aa882bc = 21:  aa882bc Only call last_indexed once, as it may be heavy
22:  660f54f = 22:  660f54f Index even empty attachments
23:  c5be1d3 = 23:  c5be1d3 As last_indexed is based on the highest insert, there will never be an UPDATE needed
24:  08610ec = 24:  08610ec Inversion of control of main indexing loops
25:  8382220 = 25:  8382220 Switch to preparing statements, rather than just setting strings
26:  1835d95 = 26:  1835d95 INSERT DELAYED provides notable speed benefits on MyISAM
27:  8947435 = 27:  8947435 Improve MySQL insert speed by batching inserts into one statement
28:  a977c6d = 28:  a977c6d Testing finds 200 is a good default batch size
29:  d26a640 = 29:  d26a640 Indexing of "text" may fail for content with invalid UTF-8 byte sequences
30:  040708f = 30:  040708f Refactor PostgreSQL's insert to also do bulk insertion
31:  d9a4fb1 = 31:  d9a4fb1 Perform PostgreSQL UPDATE statements inside of a database transaction
32:  8b2b442 = 32:  8b2b442 If a new table is used for indexing, grant rights on it
33:  52c0a3f = 33:  52c0a3f Insert data to index before creating the index
34:  de64b1c = 34:  de64b1c Switch the default Postgres index to GIN
35:  1a69286 ! 35:  b366170 Default to storing the tsvector in a new table, to speed indexing
    @@ -31,3 +31,16 @@
              default => $DEFAULT{'table'},
              silent  => !$OPT{'ask'},
          );
    +
    +diff --git a/t/fts/indexed_pg.t b/t/fts/indexed_pg.t
    +--- a/t/fts/indexed_pg.t
    ++++ b/t/fts/indexed_pg.t
    +@@
    + 
    + plan tests => 36;
    + 
    +-RT->Config->Set( FullTextSearch => Enable => 1, Indexed => 1, Column => 'ContentIndex', Table => 'Attachments' );
    ++RT->Config->Set( FullTextSearch => Enable => 1, Indexed => 1, Column => 'ContentIndex', Table => 'AttachmentsIndex' );
    + 
    + setup_indexing();
    +