[Rt-commit] [rtir] 05/14: Explicit returns for lib/RT/IR.pm

Kevin Falcone falcone at bestpractical.com
Wed Oct 8 18:11:57 EDT 2014


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.4/perlcritic
in repository rtir.

commit e629936b477f13bf27f2c163c287b1f530e731c9
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jul 22 12:35:57 2011 -0400

    Explicit returns for lib/RT/IR.pm
---
 lib/RT/IR.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/RT/IR.pm b/lib/RT/IR.pm
index 835e466..3d460d3 100644
--- a/lib/RT/IR.pm
+++ b/lib/RT/IR.pm
@@ -885,9 +885,10 @@ if ( RT::IR->HasConstituency ) {
     }
 
 
+
     # TODO SubjectTag and Encryption Keys need overriding also
-    sub CorrespondAddress { GetQueueAttribute(shift, 'CorrespondAddress') }
-    sub CommentAddress { GetQueueAttribute(shift, 'CommentAddress') }
+    sub CorrespondAddress { return GetQueueAttribute(shift, 'CorrespondAddress') }
+    sub CommentAddress { return GetQueueAttribute(shift, 'CommentAddress') }
 
     # dive down to get Queue Attributes from Incidents - EDUNET rather than Incidents
     # Populates ConstituencyCache and HasNoQueueCache, but has the same

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list