[Rt-commit] [rtir] 12/14: Standardize use strict/warnings/base header somewhat
Kevin Falcone
falcone at bestpractical.com
Wed Oct 8 18:11:58 EDT 2014
This is an automated email from the git hooks/post-receive script.
falcone pushed a commit to branch 3.4/perlcritic
in repository rtir.
commit d9057055a3e805a09e2ef6156fd53ec3b435249b
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Aug 29 18:32:41 2011 -0400
Standardize use strict/warnings/base header somewhat
---
lib/RT/Action/RTIR.pm | 2 ++
lib/RT/Action/RTIR_Activate.pm | 5 ++---
lib/RT/Action/RTIR_ChangeChildOwnership.pm | 4 +---
lib/RT/Action/RTIR_ChangeParentOwnership.pm | 4 +---
lib/RT/Action/RTIR_FindIP.pm | 3 +--
lib/RT/Action/RTIR_MergeIPs.pm | 4 +---
lib/RT/Action/RTIR_OpenParent.pm | 4 +---
lib/RT/Action/RTIR_ResolveChildren.pm | 4 +---
lib/RT/Action/RTIR_SetConstituency.pm | 4 +---
lib/RT/Action/RTIR_SetConstituencyGroup.pm | 4 +---
lib/RT/Action/RTIR_SetDueIncident.pm | 4 +---
lib/RT/Action/RTIR_SetHowReported.pm | 5 +----
lib/RT/Action/RTIR_SetIncidentResolution.pm | 4 +---
lib/RT/Condition/RTIR.pm | 8 ++++----
lib/RT/Condition/RTIR_CustomerResponse.pm | 4 +---
lib/RT/Condition/RTIR_LinkingToIncident.pm | 4 +---
lib/RT/Condition/RTIR_Merge.pm | 4 +---
lib/RT/Condition/RTIR_RequireConstituencyChange.pm | 4 +---
lib/RT/Condition/RTIR_RequireConstituencyGroupChange.pm | 4 +---
lib/RT/Condition/RTIR_RequireDueChange.pm | 4 +---
lib/RT/Condition/RTIR_RequireReportActivation.pm | 4 +---
lib/RT/Condition/RTIR_StaffResponse.pm | 4 +---
lib/RT/IR.pm | 4 +---
lib/RT/IR/Test.pm.in | 4 +---
lib/RT/IR/Test/Web.pm | 4 +---
25 files changed, 30 insertions(+), 73 deletions(-)
diff --git a/lib/RT/Action/RTIR.pm b/lib/RT/Action/RTIR.pm
index 3ae50bf..3782d1c 100644
--- a/lib/RT/Action/RTIR.pm
+++ b/lib/RT/Action/RTIR.pm
@@ -60,6 +60,8 @@ RTIR's actions don't do anything by default.
sub Prepare { return 1 }
+use RT::IR;
+
sub CreatorCurrentUser {
my $self = shift;
my $user = RT::CurrentUser->new($self->TransactionObj->CurrentUser);
diff --git a/lib/RT/Action/RTIR_Activate.pm b/lib/RT/Action/RTIR_Activate.pm
index 6c2ff64..08dd18f 100644
--- a/lib/RT/Action/RTIR_Activate.pm
+++ b/lib/RT/Action/RTIR_Activate.pm
@@ -46,11 +46,10 @@
#
# END BPS TAGGED BLOCK }}}
-use strict;
-use warnings;
-
package RT::Action::RTIR_Activate;
use base 'RT::Action::RTIR';
+use strict;
+use warnings;
=head2 Commit
diff --git a/lib/RT/Action/RTIR_ChangeChildOwnership.pm b/lib/RT/Action/RTIR_ChangeChildOwnership.pm
index b8c7b49..448731a 100644
--- a/lib/RT/Action/RTIR_ChangeChildOwnership.pm
+++ b/lib/RT/Action/RTIR_ChangeChildOwnership.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_ChangeChildOwnership;
use strict;
use warnings;
-
-package RT::Action::RTIR_ChangeChildOwnership;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Action/RTIR_ChangeParentOwnership.pm b/lib/RT/Action/RTIR_ChangeParentOwnership.pm
index 1561833..df59778 100644
--- a/lib/RT/Action/RTIR_ChangeParentOwnership.pm
+++ b/lib/RT/Action/RTIR_ChangeParentOwnership.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_ChangeParentOwnership;
use strict;
use warnings;
-
-package RT::Action::RTIR_ChangeParentOwnership;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Action/RTIR_FindIP.pm b/lib/RT/Action/RTIR_FindIP.pm
index 11846f7..4f2df1e 100644
--- a/lib/RT/Action/RTIR_FindIP.pm
+++ b/lib/RT/Action/RTIR_FindIP.pm
@@ -46,10 +46,9 @@
#
# END BPS TAGGED BLOCK }}}
+package RT::Action::RTIR_FindIP;
use strict;
use warnings;
-
-package RT::Action::RTIR_FindIP;
use base qw(RT::Action::RTIR);
use Regexp::Common qw(net);
diff --git a/lib/RT/Action/RTIR_MergeIPs.pm b/lib/RT/Action/RTIR_MergeIPs.pm
index 2a8d325..0d97b78 100644
--- a/lib/RT/Action/RTIR_MergeIPs.pm
+++ b/lib/RT/Action/RTIR_MergeIPs.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_MergeIPs;
use strict;
use warnings;
-
-package RT::Action::RTIR_MergeIPs;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Action/RTIR_OpenParent.pm b/lib/RT/Action/RTIR_OpenParent.pm
index 13157ac..9d95212 100644
--- a/lib/RT/Action/RTIR_OpenParent.pm
+++ b/lib/RT/Action/RTIR_OpenParent.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_OpenParent;
use strict;
use warnings;
-
-package RT::Action::RTIR_OpenParent;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Action/RTIR_ResolveChildren.pm b/lib/RT/Action/RTIR_ResolveChildren.pm
index afbcc14..03e7817 100644
--- a/lib/RT/Action/RTIR_ResolveChildren.pm
+++ b/lib/RT/Action/RTIR_ResolveChildren.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_ResolveChildren;
use strict;
use warnings;
-
-package RT::Action::RTIR_ResolveChildren;
use base 'RT::Action::RTIR';
=head2 Prepare
diff --git a/lib/RT/Action/RTIR_SetConstituency.pm b/lib/RT/Action/RTIR_SetConstituency.pm
index 53cca2a..c68e16d 100644
--- a/lib/RT/Action/RTIR_SetConstituency.pm
+++ b/lib/RT/Action/RTIR_SetConstituency.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_SetConstituency;
use strict;
use warnings;
-
-package RT::Action::RTIR_SetConstituency;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Action/RTIR_SetConstituencyGroup.pm b/lib/RT/Action/RTIR_SetConstituencyGroup.pm
index 0265db7..62e03c6 100644
--- a/lib/RT/Action/RTIR_SetConstituencyGroup.pm
+++ b/lib/RT/Action/RTIR_SetConstituencyGroup.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_SetConstituencyGroup;
use strict;
use warnings;
-
-package RT::Action::RTIR_SetConstituencyGroup;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Action/RTIR_SetDueIncident.pm b/lib/RT/Action/RTIR_SetDueIncident.pm
index dc3dcf0..e5c4b8e 100644
--- a/lib/RT/Action/RTIR_SetDueIncident.pm
+++ b/lib/RT/Action/RTIR_SetDueIncident.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_SetDueIncident;
use strict;
use warnings;
-
-package RT::Action::RTIR_SetDueIncident;
use base 'RT::Action::RTIR';
=head1 NAME
diff --git a/lib/RT/Action/RTIR_SetHowReported.pm b/lib/RT/Action/RTIR_SetHowReported.pm
index 0bc4082..0c1da79 100644
--- a/lib/RT/Action/RTIR_SetHowReported.pm
+++ b/lib/RT/Action/RTIR_SetHowReported.pm
@@ -45,14 +45,11 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_SetHowReported;
use strict;
use warnings;
-
-package RT::Action::RTIR_SetHowReported;
use base 'RT::Action::RTIR';
-
=head2 Commit
If the HowReported field isn't set, assume it's email.
diff --git a/lib/RT/Action/RTIR_SetIncidentResolution.pm b/lib/RT/Action/RTIR_SetIncidentResolution.pm
index e88d2b6..dbb1696 100644
--- a/lib/RT/Action/RTIR_SetIncidentResolution.pm
+++ b/lib/RT/Action/RTIR_SetIncidentResolution.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Action::RTIR_SetIncidentResolution;
use strict;
use warnings;
-
-package RT::Action::RTIR_SetIncidentResolution;
use base 'RT::Action::RTIR';
=head2 Commit
diff --git a/lib/RT/Condition/RTIR.pm b/lib/RT/Condition/RTIR.pm
index b03377e..91d9f6e 100644
--- a/lib/RT/Condition/RTIR.pm
+++ b/lib/RT/Condition/RTIR.pm
@@ -45,13 +45,13 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
-use strict;
-use warnings;
-
package RT::Condition::RTIR;
+use warnings;
+use strict;
use base 'RT::Condition';
+use RT::IR;
+
=head1 NAME
RT::Condition::RTIR - generic checks
diff --git a/lib/RT/Condition/RTIR_CustomerResponse.pm b/lib/RT/Condition/RTIR_CustomerResponse.pm
index 332eccd..ca73b64 100644
--- a/lib/RT/Condition/RTIR_CustomerResponse.pm
+++ b/lib/RT/Condition/RTIR_CustomerResponse.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_CustomerResponse;
use strict;
use warnings;
-
-package RT::Condition::RTIR_CustomerResponse;
use base 'RT::Condition::RTIR';
=head1 NAME
diff --git a/lib/RT/Condition/RTIR_LinkingToIncident.pm b/lib/RT/Condition/RTIR_LinkingToIncident.pm
index 355319e..5bdabd9 100644
--- a/lib/RT/Condition/RTIR_LinkingToIncident.pm
+++ b/lib/RT/Condition/RTIR_LinkingToIncident.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_LinkingToIncident;
use strict;
use warnings;
-
-package RT::Condition::RTIR_LinkingToIncident;
use base 'RT::Condition::RTIR';
=head2 IsApplicable
diff --git a/lib/RT/Condition/RTIR_Merge.pm b/lib/RT/Condition/RTIR_Merge.pm
index 1d7c806..cc05fd4 100644
--- a/lib/RT/Condition/RTIR_Merge.pm
+++ b/lib/RT/Condition/RTIR_Merge.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_Merge;
use strict;
use warnings;
-
-package RT::Condition::RTIR_Merge;
use base 'RT::Condition::RTIR';
=head2 IsApplicable
diff --git a/lib/RT/Condition/RTIR_RequireConstituencyChange.pm b/lib/RT/Condition/RTIR_RequireConstituencyChange.pm
index ec09563..192aa88 100644
--- a/lib/RT/Condition/RTIR_RequireConstituencyChange.pm
+++ b/lib/RT/Condition/RTIR_RequireConstituencyChange.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_RequireConstituencyChange;
use strict;
use warnings;
-
-package RT::Condition::RTIR_RequireConstituencyChange;
use base 'RT::Condition::RTIR';
=head2 IsApplicable
diff --git a/lib/RT/Condition/RTIR_RequireConstituencyGroupChange.pm b/lib/RT/Condition/RTIR_RequireConstituencyGroupChange.pm
index 0118d12..03b10eb 100644
--- a/lib/RT/Condition/RTIR_RequireConstituencyGroupChange.pm
+++ b/lib/RT/Condition/RTIR_RequireConstituencyGroupChange.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_RequireConstituencyGroupChange;
use strict;
use warnings;
-
-package RT::Condition::RTIR_RequireConstituencyGroupChange;
use base 'RT::Condition::RTIR';
=head2 IsApplicable
diff --git a/lib/RT/Condition/RTIR_RequireDueChange.pm b/lib/RT/Condition/RTIR_RequireDueChange.pm
index 240630e..e74cd0e 100644
--- a/lib/RT/Condition/RTIR_RequireDueChange.pm
+++ b/lib/RT/Condition/RTIR_RequireDueChange.pm
@@ -46,13 +46,11 @@
#
# END BPS TAGGED BLOCK }}}
+package RT::Condition::RTIR_RequireDueChange;
use strict;
use warnings;
-
-package RT::Condition::RTIR_RequireDueChange;
use base 'RT::Condition::RTIR';
-
=head2 IsApplicable
Fires scrip if this ticket had a Due date change,
diff --git a/lib/RT/Condition/RTIR_RequireReportActivation.pm b/lib/RT/Condition/RTIR_RequireReportActivation.pm
index a671775..aa5a101 100644
--- a/lib/RT/Condition/RTIR_RequireReportActivation.pm
+++ b/lib/RT/Condition/RTIR_RequireReportActivation.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_RequireReportActivation;
use strict;
use warnings;
-
-package RT::Condition::RTIR_RequireReportActivation;
use base 'RT::Condition::RTIR';
=head2 IsApplicable
diff --git a/lib/RT/Condition/RTIR_StaffResponse.pm b/lib/RT/Condition/RTIR_StaffResponse.pm
index 78b7748..a64b287 100644
--- a/lib/RT/Condition/RTIR_StaffResponse.pm
+++ b/lib/RT/Condition/RTIR_StaffResponse.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::Condition::RTIR_StaffResponse;
use strict;
use warnings;
-
-package RT::Condition::RTIR_StaffResponse;
use base 'RT::Condition::RTIR';
diff --git a/lib/RT/IR.pm b/lib/RT/IR.pm
index 403adba..0b1ca85 100644
--- a/lib/RT/IR.pm
+++ b/lib/RT/IR.pm
@@ -45,13 +45,11 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::IR;
use 5.008003;
use strict;
use warnings;
-package RT::IR;
-
our $VERSION = '3.3.HEAD';
use Scalar::Util qw(blessed);
diff --git a/lib/RT/IR/Test.pm.in b/lib/RT/IR/Test.pm.in
index a50e60f..18dd48a 100644
--- a/lib/RT/IR/Test.pm.in
+++ b/lib/RT/IR/Test.pm.in
@@ -45,15 +45,13 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::IR::Test;
use strict;
use warnings;
### after: use lib qw(@RT_LIB_PATH@);
use lib qw(/opt/rt4/local/lib /opt/rt4/lib);
-package RT::IR::Test;
-
use base 'RT::Test';
use RT::IR::Test::Web;
diff --git a/lib/RT/IR/Test/Web.pm b/lib/RT/IR/Test/Web.pm
index 954c45e..ba499be 100644
--- a/lib/RT/IR/Test/Web.pm
+++ b/lib/RT/IR/Test/Web.pm
@@ -45,11 +45,9 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
-
+package RT::IR::Test::Web;
use strict;
use warnings;
-
-package RT::IR::Test::Web;
use base qw(RT::Test::Web);
require RT::IR::Test;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the rt-commit
mailing list