[Rt-commit] [rtir] 04/05: param returns the selected value(s)

Kevin Falcone falcone at bestpractical.com
Thu Sep 25 16:15:52 EDT 2014


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.0/test-constituencies
in repository rtir.

commit cf1e6c1071e260f7d98f279512ca705096df0d61
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Sep 24 17:03:39 2014 -0400

    param returns the selected value(s)
    
    We actually want the values available. This test never tested what it
    was trying to test because it never looked at the available values, only
    the selected (default) value of GOVNET.
    
    There's no way this test could fail unless Constituency was empty (which
    is possible for certain configurations, but not tested anywhere).  Now it
    tests what it is documented to test.
---
 t/constituency/basics.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/constituency/basics.t b/t/constituency/basics.t
index c173426..a5f437e 100644
--- a/t/constituency/basics.t
+++ b/t/constituency/basics.t
@@ -57,7 +57,7 @@ diag "check that there is no option to set 'no value' on create" if $ENV{'TEST_V
         my $value = $agent->form_number(3)->value("Object-RT::Ticket--CustomField-". $cf->id ."-Values");
         is lc $value, lc $default, 'correct value is selected';
 
-        my @values = $agent->form_number(3)->param("Object-RT::Ticket--CustomField-". $cf->id ."-Values");
+        my @values = $agent->current_form->find_input("Object-RT::Ticket--CustomField-". $cf->id ."-Values")->possible_values;
         ok !grep( $_ eq '', @values ), 'have no empty value for selection';
     }
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list