[Rt-commit] rt branch, 4.2/cfv-autocomplete-limit, created. rt-4.2.7-13-gf7e3bb6

[Alex Vandiver]

The branch, 4.2/cfv-autocomplete-limit has been created
        at  f7e3bb60fbc9b399a72d05fed81ba268c627b906 (commit)

- Log -----------------------------------------------------------------
commit a90b662e310d971da87b7a2b40224c31f14d1477
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Sep 29 14:28:53 2014 -0400

    Don't hide AllowLoginPasswordAutoComplete option as a 'password'
    
    Fixes: #30417

diff --git a/share/html/Admin/Tools/Configuration.html b/share/html/Admin/Tools/Configuration.html
index 295e25e..f3da4a2 100644
--- a/share/html/Admin/Tools/Configuration.html
+++ b/share/html/Admin/Tools/Configuration.html
@@ -87,7 +87,7 @@ foreach my $key ( RT->Config->Options( Overridable => undef, Sorted => 0 ) ) {
 <tr class="<% $index_conf%2 ? 'oddline' : 'evenline'%>">
 <td class="collection-as-table"><% $key %></td>
 <td class="collection-as-table">
-% if ( $key =~ /Password(?!Length)/i ) { 
+% if ( $key =~ /Password/i and $key !~ /MinimumPasswordLength|AllowLoginPasswordAutoComplete/ ) {
 <em><% loc('Password not printed' ) %></em>\
 % } else {
 <% stringify($val) |n %>\

commit f7e3bb60fbc9b399a72d05fed81ba268c627b906
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Jul 2 13:04:52 2014 -0400

    Limit the custom field values autocompleter, like the others
    
    Default to 10 options, as the other autocompleters do.
    
    Fixes: I#30190

diff --git a/share/html/Helpers/Autocomplete/CustomFieldValues b/share/html/Helpers/Autocomplete/CustomFieldValues
index 7d512ab..ca6f067 100644
--- a/share/html/Helpers/Autocomplete/CustomFieldValues
+++ b/share/html/Helpers/Autocomplete/CustomFieldValues
@@ -125,6 +125,13 @@ $values->Limit(
     SUBCLAUSE       => 'autocomplete',
     CASESENSITIVE   => 0,
 );
+$m->callback(
+    CallbackName => 'ModifyMaxResults',
+    max => \$ARGS{max},
+    term => $term,
+    CustomField => $CustomFieldObj,
+);
+$values->RowsPerPage( $ARGS{max} // 10 );
 
 my @suggestions;
 

-----------------------------------------------------------------------