[Rt-commit] rt branch, 4.2/perlcritic, repushed

[Alex Vandiver]

The branch 4.2/perlcritic was deleted and repushed:
       was 6a864416c6d3d766585e8b91bd5dadb7e744a3d8
       now b6310843f68af632eaef3f0c29c5134acabd938b

 1:  ea77270 =  1:  ea77270 Replace the deprecated UNIVERSAL::can with $obj->can in various forms
 2:  9df264f =  2:  9df264f Replace the UNIVERSAL::isa calls which degenerate to ref() with just that
 3:  512d1c1 =  3:  512d1c1 Replace UNIVERSAL::isa checks in tests with the more correct isa_ok
 4:  9b2a834 =  4:  9b2a834 Replace UNIVERSAL::isa(errno,$id) with the certainly-intended reverse
 5:  1320d5f =  5:  1320d5f Store $@ as soon as possible in error handler
 6:  96b7a64 =  6:  96b7a64 Replace UNIVERSAL::isa(...)'s usage to mean "instanceof" with blessed && ->isa()
 7:  71c909d =  7:  71c909d Replace UNIVERSAL::isa(...)'s usage to mean "class is a subclass of" with just ->isa()
 8:  c8e1d5c =  8:  c8e1d5c Use ->can() to dispatch, rather than a string eval
 9:  0d36584 =  9:  0d36584 Don't use bareword filehandles
10:  4f81ef6 = 10:  4f81ef6 Use explicit glob() function, instead of <*>
11:  704acd0 = 11:  704acd0 Don't modify $_ in map and grep
12:  0f6c52a = 12:  0f6c52a Switch from a string eval to using UNIVERSAL::require
13:  5d632a8 = 13:  5d632a8 Remove an unnecessary use of string eval
14:  b5c263e = 14:  b5c263e Mark all of the explicitly-allowed string evals
15:  3184ae8 = 15:  3184ae8 Ensure that all loop variables are properly localized
16:  f823433 = 16:  f823433 Remove some unnecessary subroutine prototypes
17:  c38b5b3 = 17:  c38b5b3 Subroutine prototypes that start with & are of use; allow them
18:  84247aa = 18:  84247aa cmp_version is ($$) so it can be used directly by sort()
19:  0c54b97 = 19:  0c54b97 Replace several uses of stash plundering with $package->can($method)
20:  4e1225e = 20:  4e1225e We are unable to add "use strict" because of the package vars, but we can at least enable warnings
21:  7c0dd20 = 21:  7c0dd20 Remove unreachable code after unconditional return statements
22:  004cc7a = 22:  004cc7a Fix "my $x = ... if ..." traps
23:  0cbec4a ! 23:  642740f Remove a bit more indirect object notation
    @@ -53,7 +53,7 @@
                  ValuesClass => VALUES_CLASS );
      
     -my $cf = new( RT::CustomField );
    -+my $cf = RT::CustomField->new;
    ++my $cf = RT::CustomField->new( RT->SystemUser );
      isa_ok( $cf, 'RT::CustomField' );
      
      {
24:  4c3cf60 = 24:  0b4def1 Rename functions so they don't conflict with built-ins
25:  ee15f08 = 25:  f1f9efd Make all "no strict" usages be scoped to a single line
26:  e11958c = 26:  5bb73ae Remove "no warnings" lines where possible
27:  b971d4d = 27:  81f9d09 Remove instances of comma-as-statement-separator
28:  1e9dfa7 = 28:  360fa8b Rejigger some commas which perlcritic mistook for statement separators
29:  e5b9253 = 29:  4182d96 Resolve mixed high and low precedence boolean operators, in favor of low-precedence
30:  cdf66b8 = 30:  f195427 $, hasn't been a problem since Log::Dispatch 1.79; we require 2.0 in rt-test-dependencies
31:  1373a68 = 31:  e6b8ae6 Move the already-compile-time use line to the top; the version requirement is also superfluous
32:  10d1d1b = 32:  80f1976 Remove uses of lexical $a variable
33:  34f41e8 = 33:  f9b6333 Remove a case of map in void context
34:  272f684 = 34:  666e0c5 Fix cases of using $1 without checking the regex -- or perlcritic thinks we do
35:  b178945 = 35:  50caeb3 Remove variables declared but not used
36:  173b812 = 36:  a2b3957 Access config variables through RT->Config->Get rather than reaching into RT::
37:  5d81431 = 37:  8cd4a95 _WhoHaveRoleRightSplitted should have been removed from Users in 932a5a2
38:  72c6990 = 38:  5c4e302 Explicitly initialize local'd variables to undef or another appropriate value
39:  e722e4b = 39:  f17bb66 Change occurrences of split( 'string', ... ) into split( /regex/, ... )
40:  7053569 = 40:  f8b2411 Check the return value of close()
41:  d4854e7 = 41:  6715d63 Proper localization of $_ reveals wrong variable in use
42:  78d0400 = 42:  4a5b757 Remove a useless use of require "path/to/file.pm"
43:  4c97eb8 = 43:  e492df6 Move "use strict; use warnings;" to top
44:  832d3df = 44:  58e3171 Switch from lax (":utf8") to strict (":encoding(UTF-8)") layers
45:  d879d0a = 45:  1638437 Make the octal-ness of this constant explicit
46:  c1bc438 = 46:  046ee58 Add "use strict" to test plugins as well
47:  6a86441 = 47:  b631084 Move standalone t/lifecycles/utils.pl to being an RT::Test