[Rt-commit] rt branch, 4.2/more-about-requestor-list-default-tab, created. rt-4.2.12-50-g1552895

? sunnavy sunnavy at bestpractical.com
Mon Aug 17 08:44:18 EDT 2015


The branch, 4.2/more-about-requestor-list-default-tab has been created
        at  1552895ea7b58847f5e25e9d0a894278a129e7dc (commit)

- Log -----------------------------------------------------------------
commit 9a47855f2f7fa45d225d692acde1cc82676c1d1b
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Aug 17 20:38:51 2015 +0800

    fix operator precedence because "&&" binds tighter than "="

diff --git a/share/html/Ticket/Elements/ShowRequestor b/share/html/Ticket/Elements/ShowRequestor
index 266604c..e39679a 100644
--- a/share/html/Ticket/Elements/ShowRequestor
+++ b/share/html/Ticket/Elements/ShowRequestor
@@ -167,8 +167,10 @@ $ShowTickets = 0 if $DefaultTicketsTab eq 'None';
 my $TicketTemplate;
 if ($ShowTickets) {
     for (0 .. (@$status_order - 1)) {
-        $selected = $_ && last
-            if $status_order->[$_] eq $DefaultTicketsTab;
+        if ( $status_order->[$_] eq $DefaultTicketsTab ) {
+            $selected = $_;
+            last;
+        }
     }
 
     $TicketTemplate = "ShowRequestorTickets$DefaultTicketsTab";

commit 1552895ea7b58847f5e25e9d0a894278a129e7dc
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Aug 17 20:39:51 2015 +0800

    new version of tabs lib uses option "active" instead of "selected"

diff --git a/share/html/Ticket/Elements/ShowRequestor b/share/html/Ticket/Elements/ShowRequestor
index e39679a..5630efe 100644
--- a/share/html/Ticket/Elements/ShowRequestor
+++ b/share/html/Ticket/Elements/ShowRequestor
@@ -51,7 +51,7 @@
         jQuery(".more-about-requestor-tickets").tabs({
             cache: true,
             collapsible: true,
-            selected: <% $selected %>
+            active: <% $selected %>
         });
     });
 </script>

-----------------------------------------------------------------------


More information about the rt-commit mailing list