[Rt-commit] rt branch, 4.4/drop-unused-columns, repushed

[Shawn Moore]

The branch 4.4/drop-unused-columns was deleted and repushed:
       was b3787fdbd51ace83f37122cb246decf53369b180
       now 7c55d5e9b027cfcca527d8603853489e276718f5

1:  eb29b20 = 1:  eb29b20 Resolution and IssueStatement have never been used in core RT; drop them
2:  26986e3 = 2:  26986e3 EmailEncoding and WebEncoding have never been used in core RT
3:  8db7c75 = 3:  8db7c75 Drop all "external contact" columns from users
4:  e5f8c8e = 4:  e5f8c8e Drop never-used PGPKey column on users
5:  e60f391 < -:  ------- Add a "begin" upgrade step for validation
6:  b3787fd ! 5:  7c55d5e Bail out if a column we'll drop has any values
    @@ -3,12 +3,15 @@
         Bail out if a column we'll drop has any values
         
             The last thing I want is an angry email saying we dropped a
    -        column filled with irreplaceable data
    +        column filled with irreplaceable data.
    +    
    +        Moves the schema changes to be 4.3.1 since "content" would run after
    +        drop columns, making the validation too little too late.
     
    -diff --git a/etc/upgrade/4.3.0/begin b/etc/upgrade/4.3.0/begin
    +diff --git a/etc/upgrade/4.3.0/content b/etc/upgrade/4.3.0/content
     new file mode 100644
     --- /dev/null
    -+++ b/etc/upgrade/4.3.0/begin
    ++++ b/etc/upgrade/4.3.0/content
     @@
     +use strict;
     +use warnings;
    @@ -64,3 +67,115 @@
     +    },
     +);
     +
    +
    +diff --git a/etc/upgrade/4.3.0/schema.Oracle b/etc/upgrade/4.3.0/schema.Oracle
    +deleted file mode 100644
    +--- a/etc/upgrade/4.3.0/schema.Oracle
    ++++ /dev/null
    +@@
    +-ALTER TABLE Tickets
    +-  DROP (IssueStatement, Resolution);
    +-
    +-ALTER TABLE Users
    +-  DROP (EmailEncoding, WebEncoding,
    +-        ExternalContactInfoId, ContactInfoSystem, ExternalAuthId, AuthSystem,
    +-        PGPKey);
    +
    +diff --git a/etc/upgrade/4.3.0/schema.Pg b/etc/upgrade/4.3.0/schema.Pg
    +deleted file mode 100644
    +--- a/etc/upgrade/4.3.0/schema.Pg
    ++++ /dev/null
    +@@
    +-ALTER TABLE Tickets
    +-  DROP COLUMN IssueStatement,
    +-  DROP COLUMN Resolution;
    +-
    +-ALTER TABLE Users
    +-  DROP COLUMN EmailEncoding,
    +-  DROP COLUMN WebEncoding,
    +-  DROP COLUMN ExternalContactInfoId,
    +-  DROP COLUMN ContactInfoSystem,
    +-  DROP COLUMN ExternalAuthId,
    +-  DROP COLUMN AuthSystem,
    +-  DROP COLUMN PGPKey;
    +
    +diff --git a/etc/upgrade/4.3.0/schema.SQLite b/etc/upgrade/4.3.0/schema.SQLite
    +deleted file mode 100644
    +--- a/etc/upgrade/4.3.0/schema.SQLite
    ++++ /dev/null
    +@@
    +--- There is no "drop column" in SQLite
    +
    +diff --git a/etc/upgrade/4.3.0/schema.mysql b/etc/upgrade/4.3.0/schema.mysql
    +deleted file mode 100644
    +--- a/etc/upgrade/4.3.0/schema.mysql
    ++++ /dev/null
    +@@
    +-ALTER TABLE Tickets
    +-  DROP COLUMN IssueStatement,
    +-  DROP COLUMN Resolution;
    +-
    +-ALTER TABLE Users
    +-  DROP COLUMN EmailEncoding,
    +-  DROP COLUMN WebEncoding,
    +-  DROP COLUMN ExternalContactInfoId,
    +-  DROP COLUMN ContactInfoSystem,
    +-  DROP COLUMN ExternalAuthId,
    +-  DROP COLUMN AuthSystem,
    +-  DROP COLUMN PGPKey;
    +
    +diff --git a/etc/upgrade/4.3.1/schema.Oracle b/etc/upgrade/4.3.1/schema.Oracle
    +new file mode 100644
    +--- /dev/null
    ++++ b/etc/upgrade/4.3.1/schema.Oracle
    +@@
    ++ALTER TABLE Tickets
    ++  DROP (IssueStatement, Resolution);
    ++
    ++ALTER TABLE Users
    ++  DROP (EmailEncoding, WebEncoding,
    ++        ExternalContactInfoId, ContactInfoSystem, ExternalAuthId, AuthSystem,
    ++        PGPKey);
    +
    +diff --git a/etc/upgrade/4.3.1/schema.Pg b/etc/upgrade/4.3.1/schema.Pg
    +new file mode 100644
    +--- /dev/null
    ++++ b/etc/upgrade/4.3.1/schema.Pg
    +@@
    ++ALTER TABLE Tickets
    ++  DROP COLUMN IssueStatement,
    ++  DROP COLUMN Resolution;
    ++
    ++ALTER TABLE Users
    ++  DROP COLUMN EmailEncoding,
    ++  DROP COLUMN WebEncoding,
    ++  DROP COLUMN ExternalContactInfoId,
    ++  DROP COLUMN ContactInfoSystem,
    ++  DROP COLUMN ExternalAuthId,
    ++  DROP COLUMN AuthSystem,
    ++  DROP COLUMN PGPKey;
    +
    +diff --git a/etc/upgrade/4.3.1/schema.SQLite b/etc/upgrade/4.3.1/schema.SQLite
    +new file mode 100644
    +--- /dev/null
    ++++ b/etc/upgrade/4.3.1/schema.SQLite
    +@@
    ++-- There is no "drop column" in SQLite
    +
    +diff --git a/etc/upgrade/4.3.1/schema.mysql b/etc/upgrade/4.3.1/schema.mysql
    +new file mode 100644
    +--- /dev/null
    ++++ b/etc/upgrade/4.3.1/schema.mysql
    +@@
    ++ALTER TABLE Tickets
    ++  DROP COLUMN IssueStatement,
    ++  DROP COLUMN Resolution;
    ++
    ++ALTER TABLE Users
    ++  DROP COLUMN EmailEncoding,
    ++  DROP COLUMN WebEncoding,
    ++  DROP COLUMN ExternalContactInfoId,
    ++  DROP COLUMN ContactInfoSystem,
    ++  DROP COLUMN ExternalAuthId,
    ++  DROP COLUMN AuthSystem,
    ++  DROP COLUMN PGPKey;