[Rt-commit] [rtir] 01/01: Remove the ?id= on DisplayPath, which is added by ShowTransaction

[Alex Vandiver]

This is an automated email from the git hooks/post-receive script.

alexmv pushed a commit to branch 3.2/displaypath-id
in repository rtir.

commit 92355640e24aabd24512025b8822dc381f563759
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Mar 11 11:34:00 2015 -0400

    Remove the ?id= on DisplayPath, which is added by ShowTransaction
    
    share/html/Elements/ShowTransaction in RT automatically appends the
    query parameters, including ?id=..., to the provided $DisplayPath.
    Setting it explicitly constructs URLs like 'Display.html?id=42?id=42'
    which fail to work.
    
    Fixes: I#30744
---
 html/Callbacks/RTIR/Helpers/TicketHistory/ExtraShowHistoryArguments | 2 +-
 html/RTIR/Display.html                                              | 2 +-
 html/RTIR/Incident/Display.html                                     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/html/Callbacks/RTIR/Helpers/TicketHistory/ExtraShowHistoryArguments b/html/Callbacks/RTIR/Helpers/TicketHistory/ExtraShowHistoryArguments
index 28f0362..cff0348 100644
--- a/html/Callbacks/RTIR/Helpers/TicketHistory/ExtraShowHistoryArguments
+++ b/html/Callbacks/RTIR/Helpers/TicketHistory/ExtraShowHistoryArguments
@@ -51,7 +51,7 @@ return unless $type;
 
 my $id = $Ticket->Id;
 %$ExtraArgs = (
-        DisplayPath    => RT->Config->Get('WebPath') ."/RTIR/Display.html?id=$id",
+        DisplayPath    => RT->Config->Get('WebPath') ."/RTIR/Display.html",
         UpdatePath     => RT->Config->Get('WebPath') ."/RTIR/Update.html",
         ForwardPath    => RT->Config->Get('WebPath') ."/RTIR/Forward.html",
         EncryptionPath => RT->Config->Get('WebPath') ."/RTIR/Crypt.html",
diff --git a/html/RTIR/Display.html b/html/RTIR/Display.html
index c029259..44c0dbf 100644
--- a/html/RTIR/Display.html
+++ b/html/RTIR/Display.html
@@ -144,7 +144,7 @@
     <& /Elements/ShowHistory,
         Object         => $Ticket,
         ShowHeaders    => $ARGS{'ShowHeaders'},
-        DisplayPath    => RT->Config->Get('WebPath') ."/RTIR/Display.html?id=$id",
+        DisplayPath    => RT->Config->Get('WebPath') ."/RTIR/Display.html",
         UpdatePath     => RT->Config->Get('WebPath') ."/RTIR/Update.html",
         ForwardPath    => RT->Config->Get('WebPath') ."/RTIR/Forward.html",
         EncryptionPath => RT->Config->Get('WebPath') ."/RTIR/Crypt.html",
diff --git a/html/RTIR/Incident/Display.html b/html/RTIR/Incident/Display.html
index 3646d64..89847a4 100644
--- a/html/RTIR/Incident/Display.html
+++ b/html/RTIR/Incident/Display.html
@@ -139,7 +139,7 @@
     <& /Elements/ShowHistory,
         Object         => $TicketObj,
         ShowHeaders    => $ARGS{'ShowHeaders'},
-        DisplayPath    => RT->Config->Get('WebPath') ."/RTIR/Display.html?id=$id",
+        DisplayPath    => RT->Config->Get('WebPath') ."/RTIR/Display.html",
         UpdatePath     => RT->Config->Get('WebPath') ."/RTIR/Update.html",
         ForwardPath    => RT->Config->Get('WebPath') ."/RTIR/Forward.html",
         EncryptionPath => RT->Config->Get('WebPath') ."/RTIR/Crypt.html",

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.