[Rt-commit] rt branch, 4.4/gateway-refactor, repushed

[Alex Vandiver]

The branch 4.4/gateway-refactor was deleted and repushed:
       was 07205cc5244dd1c2d36fe169438c59b7e2683c17
       now 140d5c84e757692692b13803b058c74783a45346

 1:  e0497a2 =  1:  e0497a2 RT::Interface::Email doesn't need to be an Exporter
 2:  e3399f0 =  2:  e3399f0 Reorder functions to more obviously split sending and receiving mail
 3:  2a14662 =  3:  2a14662 Adjust POD headers to reflect split
 4:  99624a2 =  4:  99624a2 Update MailPlugins to only reference existant modules
 5:  00d0850 =  5:  00d0850 Move MailPlugins documentation out of rt-mailgate, where is is mostly irrelevant
 6:  8400ff9 =  6:  8400ff9 Remove duplicate ParseCcAddressesFromHead in RT::EmailParser
 7:  7b68589 =  7:  7b68589 Use Scope::Upper to allow returns from Gateway from nested subs
 8:  d358013 =  8:  d358013 Add a base email plugin role, which provides TMPFAIL/FAILURE/SUCCESS
 9:  aee7869 =  9:  aee7869 Check if each named mail plugin DOES the mail plugin role
10:  049f74d = 10:  049f74d Return values of ApplyBeforeDecode plugins' GetCurrentUser are irrelevant
11:  cae6a89 = 11:  cae6a89 Push bounce short-circuiting down into _HandleMachineGeneratedMail
12:  afe6659 = 12:  afe6659 $IsALoop is now unused in Gateway
13:  dc1f8fe = 13:  dc1f8fe Stop moving RT-Squelch-Replies-To aside
14:  03979a3 = 14:  03979a3 Simplify _HandleMachineGeneratedMail logic
15:  1a1d88f = 15:  1a1d88f Use different method names rather than an ApplyBeforeDecode method
16:  202a69f = 16:  202a69f Use FAILURE to abort from GetCurrentUser, rather than a magic -1 value
17:  19f7ec5 = 17:  19f7ec5 Remove the unused $error variable
18:  332f4d2 = 18:  332f4d2 Move $Right to where it is used
19:  a418722 = 19:  a418722 Move SystemTicket definition to where it is first used
20:  d20810a ! 20:  8ae942f Move NewSubject to where it is used
    @@ -20,8 +20,6 @@
                  );
              }
      
    -+        $head->replace('X-RT-Interface' => 'Email');
    -+
     +        # ExtractTicketId may have been overridden, and edited the Subject
     +        my $NewSubject = Encode::decode( "UTF-8", $head->get('Subject') );
     +        chomp $NewSubject;
21:  4f62568 = 21:  24bf62a Remove CreateUser, merging to form a more featureful LoadOrCreateByEmail
22:  4a1477c = 22:  6dd0a29 Always create the user; this simplifies ACL checking greatly
23:  0663fc2 = 23:  39d8b60 Split authentication from authorization
24:  fea5585 = 24:  d6b673a Remove no-longer-used _NoAuthorizedUserFound
25:  5b57ea2 = 25:  7408373 Remove now-unused $Right variable, previously used by _NoAuthorizedUserFound
26:  6f745ff = 26:  ddd1c03 Fail if the first action is unauthenticated
27:  feb1bea = 27:  03d0af9 Notify the owner on common mis-configurations
28:  3693492 = 28:  12115ef Remove extra error in mail-gateway
29:  f50d4d1 = 29:  096152b Add back a warning that is now lacking
30:  eb99759 = 30:  3079bf8 Stop passing mail plugins around; load them lazily in one Plugins() method
31:  d079e0b ! 31:  5ccf5a1 Split action handling into plugin classes
    @@ -127,8 +127,6 @@
     -                QueueObj    => $SystemQueueObj
     -            );
     -        }
    --
    --        $head->replace('X-RT-Interface' => 'Email');
     -
     -        # ExtractTicketId may have been overridden, and edited the Subject
     -        my $NewSubject = Encode::decode( "UTF-8", $head->get('Subject') );
    @@ -434,10 +432,8 @@
     +            qw(To Cc);
     +    }
     +
    -+    $head->replace('X-RT-Interface' => 'Email');
    -+
     +    # ExtractTicketId may have been overridden, and edited the Subject
    -+    my $subject = $head->get('Subject');
    ++    my $subject = Encode::decode( "UTF-8", $head->get('Subject') );
     +    chomp $subject;
     +
     +    my ( $id, $Transaction, $ErrStr ) = $args{Ticket}->Create(
32:  78e1e20 = 32: 2f24bb09 Plugins may alter @actions; ensure action is valid prior to calling
33:  fff20a1 = 33:  a6838f4 Split default authentication from default authorization
34:  6f4e25e = 34:  4651652 Local'ize MailErrors to avoid having to pass $ErrorsTo everywhere
35:  9134faf = 35:  3539367 Remove the warning about the deprecated Auth::GnuPG/Auth::SMIME plugins
36:  35d734d = 36:  384caa6 Allow lazy adding of Auth::MailFrom if no other GetCurrentUser plugins exist
37:  c28e1a6 = 37:  b33b8a4 There is no reason to not always enable Auth::Crypt
38:  2de26cc = 38:  59f1c3c Make Crypt not an Auth:: plugin, but hardcoded
39:  6c92abb = 39:  9af3360 Move RejectOnUnencrypted to being a mail plugin
40:  9dae096 = 40:  65d32d4 Merge ParseAddressFromHeader and RT::EmailParser->ParseEmailAddress
41:  82268d5 = 41:  8c71c0f Fix callsites of ParseSenderAddressFromHead to be slightly less incomprehensible
42:  c2c7245 = 42:  b735284 $MessageId is only used in IsMachineGeneratedMail; move it in there
43:  fde2bf8 = 43:  f71f257 Merge CheckForSuspiciousSender, CheckForAutoGenerated, and CheckForBounce
44:  f00573a = 44:  b1ea355 Reduce repetition by making MailError handle throwing the FAILURE, as well
45:  5a17739 = 45:  a008d0a Move ACL checking for Take and Resolve into their own plugins
46:  07205cc = 46:  140d5c8 Update POD for new methods and functionality