[Rt-commit] [rtir] 01/01: use new queue check code for actions/conditions

? sunnavy sunnavy at bestpractical.com
Tue Mar 17 10:23:19 EDT 2015


This is an automated email from the git hooks/post-receive script.

sunnavy pushed a commit to branch 3.4/remove_old_constituencies_abstract_queue_check
in repository rtir.

commit 1962f095f75e266fa78ff83b60c1b771e97bd19e
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Mar 17 22:19:08 2015 +0800

    use new queue check code for actions/conditions
---
 lib/RT/Action/RTIR_SetDueIncident.pm       | 4 ++--
 lib/RT/Condition/RTIR_LinkingToIncident.pm | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/RT/Action/RTIR_SetDueIncident.pm b/lib/RT/Action/RTIR_SetDueIncident.pm
index db63ed8..5e7812e 100644
--- a/lib/RT/Action/RTIR_SetDueIncident.pm
+++ b/lib/RT/Action/RTIR_SetDueIncident.pm
@@ -74,7 +74,7 @@ Performs update.
 sub Commit {
     my $self = shift;
 
-    if ( $self->TicketObj->QueueObj->Lifecycle eq 'incidents' ) {
+    if ( RT::IR->IsIncidentQueue($self->TicketObj->QueueObj) ) {
         return $self->UpdateDue( $self->TicketObj );
     }
 
@@ -97,7 +97,7 @@ sub UpdateDue {
     my $self = shift;
     my $incident = shift;
     return 1 unless $incident;
-    return 1 unless $incident->QueueObj->Lifecycle eq 'incidents';
+    return 1 unless RT::IR->IsIncidentQueue($incident->QueueObj);
 
     my $children = RT::IR->IncidentChildren(
         $incident, Initial => 1, Active => 1,
diff --git a/lib/RT/Condition/RTIR_LinkingToIncident.pm b/lib/RT/Condition/RTIR_LinkingToIncident.pm
index f04a187..4b613b7 100644
--- a/lib/RT/Condition/RTIR_LinkingToIncident.pm
+++ b/lib/RT/Condition/RTIR_LinkingToIncident.pm
@@ -80,7 +80,7 @@ sub IsApplicable {
             RT->Logger->error( "Couldn't load linked ticket #". $self->TransactionObj->NewValue ." $msg");
             return 0;
         }
-        return $parent->QueueObj->Lifecycle eq 'incidents';
+        return RT::IR->IsIncidentQueue($parent->QueueObj);
     }
     elsif ( $type eq 'AddLink' && $field eq 'MergedInto' ) {
         return RT::IR->Incidents( $self->TicketObj )->Count;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list