[Rt-commit] rt branch, 4.2/group-member-sort-order, repushed

[Alex Vandiver]

The branch 4.2/group-member-sort-order was deleted and repushed:
       was 0a52dfe8c112cd9f37c940253064a2856a5004a2
       now a5f62fd949806162f8a86acbd9f811f9f5f3f8d3

1:  f84b50d ! 1:  77c5646 Stop wrapping ShowUser in <a> tags
    @@ -53,3 +53,78 @@
      %      $session{CurrentUser}->HasRight( Right => 'ShowConfigTab', Object =>$RT::System ) ) {
      <a href="<% RT->Config->Get('WebPath') %>/Admin/Groups/Modify.html?id=<% $watcher->MemberId %>">
     
    +diff --git a/t/web/ticket_modify_people.t b/t/web/ticket_modify_people.t
    +--- a/t/web/ticket_modify_people.t
    ++++ b/t/web/ticket_modify_people.t
    +@@
    + use strict;
    + use warnings;
    + 
    +-use RT::Test tests => 25;
    ++use RT::Test tests => undef;
    + 
    + my $root = RT::Test->load_or_create_user( Name => 'root' );
    + my $group_foo = RT::Group->new($RT::SystemUser);
    +@@
    + $m->get_ok( $url . "/Ticket/ModifyPeople.html?id=" . $ticket->id );
    + 
    + ok(
    +-    !$m->find_link(
    +-        text      => 'Enoch Root',
    +-        url_regex => qr!/Admin/Users/Modify\.html!,
    ++    $m->find_link(
    ++        text      => 'root (Enoch Root)',
    ++        url_regex => qr!/User/Summary\.html!,
    +     ),
    +-    'no link to modify user'
    ++    'contains link to user summary page'
    + );
    + $m->content_contains('Enoch Root', 'still has the user name' );
    + 
    +@@
    + 
    + $m->content_contains('group_foo', 'still has the group name' );
    + 
    +-ok( RT::Test->add_rights( { Principal => $user, Right => ['AdminUsers'] }, ),
    +-    'added AdminUsers right' );
    +-$m->reload;
    +-ok(
    +-    !$m->find_link(
    +-        text      => 'Enoch Root',
    +-        url_regex => qr!/Admin/Users/Modify\.html!,
    +-    ),
    +-    'still no link to modify user'
    +-);
    +-ok(
    +-    !$m->find_link(
    +-        text      => 'group_foo',
    +-        url_regex => qr!/Admin/Groups/Modify\.html!,
    +-    ),
    +-    'still no link to modify group'
    +-);
    +-
    + ok(
    +     RT::Test->add_rights( { Principal => $user, Right => ['ShowConfigTab'] }, ),
    +     'added ShowConfigTab right',
    +@@
    + ok(
    +     $m->find_link(
    +         text      => 'root (Enoch Root)',
    +-        url_regex => qr!/Admin/Users/Modify\.html!,
    ++        url_regex => qr!/User/Summary\.html!,
    +     ),
    +-    'got link to modify user'
    ++    'still contains link to user summary page'
    + );
    + 
    + ok(
    +@@
    + my $foo = RT::Test->load_or_create_user( EmailAddress => 'foo at example.com' );
    + is $foo->RealName, "Foo Bar", "RealName matches";
    + 
    ++undef $m;
    ++done_testing;
    ++
    + # TODO test Add|Delete people
    + 
    +
2:  04f9290 = 2:  7eccdee Sort by text-only representation of the user, not HTML
3:  0a52dfe = 3:  a5f62fd Stop pre-computing ShowUser