[Rt-commit] rt branch, 4.4/external-storage, updated. rt-4.2.11-21-gf73eb38

[Shawn Moore]

The branch, 4.4/external-storage has been updated
       via  f73eb383c689965841c00a5d2c0a468650260c70 (commit)
       via  a6477401f392383d949df356ae057e33c45b9c5b (commit)
      from  ce9a822ef34ef936b5c706889556119d017e6622 (commit)

Summary of changes:
 lib/RT/ExternalStorage.pm         | 41 +++++++++++++++------------------------
 lib/RT/ExternalStorage/Backend.pm |  1 +
 2 files changed, 17 insertions(+), 25 deletions(-)

- Log -----------------------------------------------------------------
commit a6477401f392383d949df356ae057e33c45b9c5b
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Thu May 21 21:39:23 2015 +0000

    Unify installation and configuration
    
        These no longer make sense as separate steps, now that it's core RT

diff --git a/lib/RT/ExternalStorage.pm b/lib/RT/ExternalStorage.pm
index 6c06ace..cdaf35f 100644
--- a/lib/RT/ExternalStorage.pm
+++ b/lib/RT/ExternalStorage.pm
@@ -84,29 +84,37 @@ durable to transient failures of cloud connectivity.  The provided
 C<sbin/rt-externalize-attachments> script, to be run regularly via cron,
 takes care of moving attachments out of the database at a later time.
 
-=head1 INSTALLATION
+=head1 SETUP
+
+=head2 Edit F</opt/rt4/etc/RT_SiteConfig.pm>
+
+You will need to configure the C<%ExternalStorage> option,
+depending on how and where you want your data stored.
+
+RT comes with a number of possible storage backends; see the
+documentation in each for necessary configuration details:
 
 =over
 
-=item Edit your F</opt/rt4/etc/RT_SiteConfig.pm>
+=item L<RT::ExternalStorage::Disk>
 
-You will also need to configure the C<%ExternalStorage> option,
-depending on how and where you want your data stored; see
-L</CONFIGURATION>.
+=item L<RT::ExternalStorage::Dropbox>
 
-=item Restart your webserver
+=item L<RT::ExternalStorage::AmazonS3>
+
+=head2 Restart your webserver
 
 Restarting the webserver before the next step (extracting existing
 attachments) is important to ensure that files remain available as they
 are extracted.
 
-=item Extract existing attachments
+=head2 Extract existing attachments
 
 Run C<sbin/rt-externalize-attachments>; this may take some time, depending
 on the existing size of the database.  This task may be safely cancelled
 and re-run to resume.
 
-=item Schedule attachments extraction
+=head2 Schedule attachments extraction
 
 Schedule C<sbin/rt-externalize-attachments> to run at regular intervals via
 cron.  For instance, the following F</etc/cron.d/rt> entry will run it
@@ -115,23 +123,6 @@ when RT is less in use:
 
     0 0 * * * root /opt/rt4/sbin/rt-externalize-attachments
 
-=back
-
-=head1 CONFIGURATION
-
-This module comes with a number of possible backends; see the
-documentation in each for necessary configuration details:
-
-=over
-
-=item L<RT::ExternalStorage::Disk>
-
-=item L<RT::ExternalStorage::Dropbox>
-
-=item L<RT::ExternalStorage::AmazonS3>
-
-=back
-
 =head1 CAVEATS
 
 This feature is not currently compatible with RT's C<shredder> tool;

commit f73eb383c689965841c00a5d2c0a468650260c70
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Thu May 21 21:40:29 2015 +0000

    Explain empty if block

diff --git a/lib/RT/ExternalStorage/Backend.pm b/lib/RT/ExternalStorage/Backend.pm
index c3f987a..b753321 100644
--- a/lib/RT/ExternalStorage/Backend.pm
+++ b/lib/RT/ExternalStorage/Backend.pm
@@ -66,6 +66,7 @@ sub new {
         RT->Logger->error("No storage engine type provided");
         return undef;
     } elsif ($class->require) {
+        # no action needed; $class was loaded
     } else {
         my $long = "RT::ExternalStorage::$class";
         if ($long->require) {

-----------------------------------------------------------------------