[Rt-commit] rt branch, 4.4/external-storage, updated. rt-4.2.11-31-g55b3d17

Shawn Moore shawn at bestpractical.com
Thu May 21 19:18:55 EDT 2015


The branch, 4.4/external-storage has been updated
       via  55b3d178e0e3e0da0afc62a0d66671abb07743d8 (commit)
      from  0b02f39a626797866990c102a18a5ecb65125b39 (commit)

Summary of changes:
 sbin/rt-externalize-attachments.in | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit 55b3d178e0e3e0da0afc62a0d66671abb07743d8
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Thu May 21 23:18:33 2015 +0000

    Use OPERATOR => 'IN'
    
        Now that it's core RT, we know it'll always be there

diff --git a/sbin/rt-externalize-attachments.in b/sbin/rt-externalize-attachments.in
index ad99867..90344b4 100755
--- a/sbin/rt-externalize-attachments.in
+++ b/sbin/rt-externalize-attachments.in
@@ -122,12 +122,12 @@ for my $class (qw/RT::Attachments RT::ObjectCustomFieldValues/) {
                 TABLE2 => 'CustomFields',
                 FIELD2 => 'id',
             );
-            # TODO: use IN operator once we increase required RT version to 4.2
             $attach->Limit(
-                ALIAS => $cfs,
-                FIELD => "Type",
-                VALUE => $_,
-            ) for qw(Binary Image);
+                ALIAS    => $cfs,
+                FIELD    => 'Type',
+                OPERATOR => 'IN',
+                VALUE    => [ qw(Binary Image) ],
+            );
             $attach->{'find_expired_rows'} = 1;
         }
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list