[Rt-commit] rt branch, 4.2-trunk, updated. rt-4.2.12-52-gcdf9c9f

? sunnavy sunnavy at bestpractical.com
Fri Oct 2 14:46:16 EDT 2015


The branch, 4.2-trunk has been updated
       via  cdf9c9fe4297aebb158e75a0e35faf79b29a32fb (commit)
      from  4c0d85c3a090909df644e7c46926bcc3c1ef5703 (commit)

Summary of changes:
 lib/RT/Transaction.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit cdf9c9fe4297aebb158e75a0e35faf79b29a32fb
Author: Christian Loos <cloos at netcologne.de>
Date:   Thu Jun 11 09:39:31 2015 +0200

    show the queue id if the user can't see the queue name
    
    Show the queue id if the user doesn't have sufficient rights to see
    the queue name.
    
    If you move a ticket from queue q1 to q2 and the user have SeeQueue (and
    ShowTicket) on q2 but not on q1, the descriptions shows previously
    'Queue changed from to q2', which isn't very helpfull. Showing the queue
    id gives the user a hint to tell the admin which queue he can't see.
    
    This makes the queue display consistent with /Ticket/Elements/ShowQueue.
    
    This also fixes the following warnings:
    Use of uninitialized value $_[2] in join or string
    Use of uninitialized value $_[3] in join or string

diff --git a/lib/RT/Transaction.pm b/lib/RT/Transaction.pm
index ec759d3..85d5b4b 100644
--- a/lib/RT/Transaction.pm
+++ b/lib/RT/Transaction.pm
@@ -1197,7 +1197,7 @@ sub _FormatUser {
             my $q2 = RT::Queue->new( $self->CurrentUser );
             $q2->Load( $self->NewValue );
             return ("[_1] changed from [_2] to [_3]",
-                    $self->loc($self->Field) , $q1->Name , $q2->Name);  #loc()
+                    $self->loc($self->Field), $q1->Name // '#'.$q1->id, $q2->Name // '#'.$q2->id); #loc()
         }
 
         # Write the date/time change at local time:

-----------------------------------------------------------------------


More information about the rt-commit mailing list