[Rt-commit] [rtir] 01/01: change MakeClicky links in transactions to look like buttons with 'button' class

Dustin Graves dustin at bestpractical.com
Tue Oct 20 13:11:51 EDT 2015


This is an automated email from the git hooks/post-receive script.

dustin pushed a commit to branch 3.4/make-clicky-buttons
in repository rtir.

commit c059787f187c3781e34fb02db331856b4837e014
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Tue Oct 20 17:10:06 2015 +0000

    change MakeClicky links in transactions to look like buttons with 'button' class
---
 html/Callbacks/RTIR/Elements/MakeClicky/Default | 40 ++++++++++++-------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/html/Callbacks/RTIR/Elements/MakeClicky/Default b/html/Callbacks/RTIR/Elements/MakeClicky/Default
index 6116f7d..2cf936a 100644
--- a/html/Callbacks/RTIR/Elements/MakeClicky/Default
+++ b/html/Callbacks/RTIR/Elements/MakeClicky/Default
@@ -76,8 +76,8 @@ my %actions;
         # don't execute on non-rtir tickets
         return $super unless defined $args{type};
 
-        my $result = qq{[<a href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
-            .loc('lookup "[_1]"', $host) .qq{</a>]};
+        my $result = qq{<a class="button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
+            .loc('lookup "[_1]"', $host) .qq{</a>};
         return $super . qq{ <span class="clickylink">$result</span>};
     },
     url_overwrite => sub {
@@ -90,8 +90,8 @@ my %actions;
         # don't execute on non-rtir tickets
         return $super unless defined $args{type};
 
-        my $result = qq{[<a href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
-            .loc('lookup "[_1]"', $host) .qq{</a>]};
+        my $result = qq{<a class="button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=host&q=".$escaped_host).qq{">}
+            .loc('lookup "[_1]"', $host) .qq{</a>};
         return $super . qq{ <span class="clickylink">$result</span>};
     },
     ip => sub {
@@ -102,21 +102,21 @@ my %actions;
 
         $args{host} ||= $args{value};
         my $escaped_host = $escaper->($args{host});
-        my $result .= qq{[<a href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=ip&q=".$escaped_host).qq{">}
-                      .loc('lookup IP') .q{</a>]};
+        my $result .= qq{<a class="button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=ip&q=".$escaped_host).qq{">}
+                      .loc('lookup IP') .q{</a>};
         if ( $args{incident} && !RT->Config->Get('RTIR_DisableBlocksQueue') ) {
-            $result .= qq{[<a href="} .
+            $result .= qq{<a class="button" href="} .
             RT::IR->HREFTo("Create.html?Incident=".$args{incident}."&Lifecycle=".RT::IR->lifecycle_countermeasure.qq{&IP-Value=$escaped_host})
-            .qq{">block</a>]};
+            .qq{">block</a>};
         }
         if ( $args{'object'} && $args{'object'}->id ) {
             my $cf = RT::IR::GetCustomField('IP');
             my $tid = $args{'object'}->id;
-            $result .= qq{[<a href="}.
+            $result .= qq{<a class="button" href="}.
             RT::IR->HREFTo("Edit.html?id=".$tid
                 .qq{&Object-RT::Ticket-$tid-CustomField-}. $cf->id .qq{-AddValue=$escaped_host}
                 .q{&SaveChanges=1})
-                .qq{">}. loc('Add IP') .q{</a>]};
+                .qq{">}. loc('Add IP') .q{</a>};
         }
         return $escaper->($args{value}) . qq{ <span class="clickylink">$result</span>};
     },
@@ -148,25 +148,25 @@ my %actions;
         my $email = $args{'value'}; $email =~ s/^<|>$//g;
         my $escaped_email = $escaper->($email);
 
-        my $result = qq{[<a href="}.
+        my $result = qq{<a class="button" href="}.
             RT::IR->HREFTo(qq{Tools/Lookup.html?$args{'lookup_params'}type=email&q=$escaped_email}). qq{">}
-            .loc('lookup email') .q{</a>]};
+            .loc('lookup email') .q{</a>};
         if ( $args{'incident'} ) {
             if ( $r->uri =~ /Lookup.html$/ ) {
                 $result .= qq{<input type="checkbox" name="Requestorbox-$escaped_email" unchecked />};
             }
-            $result .= qq{[<a href="}.
+            $result .= qq{<a class="button" href="}.
                 RT::IR->HREFTo( "Create.html"
                 . qq{?Incident=$args{'incident'}}
                 . qq{&Lifecycle=}.RT::IR->lifecycle_investigation
                 . "&Requestors=$escaped_email")
                 . qq{">}
-                . loc('Investigate to') .qq{</a>]};
+                . loc('Investigate to') .qq{</a>};
         }
         my $domain = (split /@/, $email, 2)[1];
         my $escaped_domain = $escaper->($domain);
-        $result .= ' [<a href="'. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{'lookup_params'}type=host&q=$escaped_domain}). '">'
-               .loc('lookup "[_1]"', $domain) .'</a>]';
+        $result .= ' <a class="button" href="'. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{'lookup_params'}type=host&q=$escaped_domain}). '">'
+               .loc('lookup "[_1]"', $domain) .'</a>';
         return $escaper->($args{'value'}) . qq{ <span class="clickylink">$result</span>};
     },
     noc => sub {
@@ -176,8 +176,8 @@ my %actions;
         return $escaper->($args{value}) unless defined $args{type};
 
         $args{value} = $escaper->($args{value});
-        my $result = qq{[<a href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=handle&q=$args{value}}).qq{">}
-               .loc('lookup') .qq{</a>]};
+        my $result = qq{<a class="button" href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=handle&q=$args{value}}).qq{">}
+               .loc('lookup') .qq{</a>};
         return $args{value} . qq{ <span class="clickylink">$result</span>};
     },
     host => sub {
@@ -187,8 +187,8 @@ my %actions;
         return $escaper->($args{value}) unless defined $args{type};
 
         $args{value} = $escaper->($args{value});
-        my $result = qq{[<a href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=host&q=$args{value}}). qq{">}
-               .loc('lookup host') .qq{</a>]};
+        my $result = qq{<a class="button" href="}. RT::IR->HREFTo(qq{Tools/Lookup.html?$args{lookup_params}type=host&q=$args{value}}). qq{">}
+               .loc('lookup host') .qq{</a>};
         return $args{value} . qq{ <span class="clickylink">$result</span>};
     },
 );

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list