[Rt-commit] rt branch, 4.4/custom-roles, repushed

[Shawn Moore]

The branch 4.4/custom-roles was deleted and repushed:
       was 978dd729de1350c121626bec65848da871ce7a65
       now ed0ff0ce8be0d6b511c8cdee6aed5b4e03c8addf

 1:  3da168a =  1:  3da168a Tidy EmailInput and avoid including unescaped parameters
 2:  f4a3966 =  2:  f4a3966 Placeholder and EntryHint for EmailInput
 3:  5b777ea =  3:  5b777ea Support autocomplete-return for EmailInput
 4:  1168416 =  4:  1168416 Support for (by default, off) autocomplete of Nobody and System
 5:  87d20c2 =  5:  87d20c2 Only include one copy of "check box to delete" for queue watchers
 6:  7c59fae =  6:  7c59fae Simplify IsManageableRoleGroupType
 7:  ce5900a =  7:  ce5900a Switch several hardcoded lists to use ->Roles
 8:  e5b9caa =  8:  e5b9caa Avoid empty results and undef warnings in bulk update
 9:  b9ef253 =  9:  b9ef253 Tidy AddWatchers
10:  5e0924c = 10:  5e0924c Use the record we have for inspecting roles, rather than class RT::Queue
11:  7f93bb4 = 11:  7f93bb4 Add a CheckRight param to ->RoleGroup
12:  6d51036 = 12:  6d51036 Fix one-off "Administrative Cc" with "AdminCc"
13:  319727e = 13:  319727e Provide queue to EditBasics for new tickets that don't have a ->QueueObj
14:  b4f7d39 = 14:  b4f7d39 Provide defaults to EditBasics for "Add More Attach" etc
15:  be9c040 = 15:  be9c040 Factor out a CanonicalizePrincipal from AddRoleMember
16:  dc9cbb0 = 16:  dc9cbb0 Consistent error message across AddRoleMember and DeleteRoleMember
17:  1a64c0e = 17:  1a64c0e Factor out a _CreateRoleGroup
18:  0ac9041 = 18:  0ac9041 Lazily create ticket role groups if needed
19:  2dd0512 = 19:  2dd0512 Use queue to resolve roles on create since the ticket isn't created yet
20:  fa5e8fc = 20:  fa5e8fc Process watcher updates from ticket Modify
21:  434eaec = 21:  434eaec Improve messaging around updating queue/ticket watchers
22:  c25583c = 22:  c25583c Additional option for roles
23:  23b15ab = 23:  23b15ab Tidy watcher searching in RT::Tickets
24:  1ed2e23 = 24:  1ed2e23 Improve comments around GetPrincipalsMap
25:  b14540f = 25:  b14540f Add a Group->Label hook for when we display a group's name in the UI
26:  936e744 = 26:  936e744 Switch to ->LabelForRole
27:  f567601 ! 27:  3dcd0eb Add custom roles for queues
    @@ -1282,7 +1282,7 @@
          }
      
     +    if ($self->Domain =~ /-Role$/) {
    -+        my ($id) = $name =~ /^RT::CustomRole-(\d+)$/;
    ++        my ($id) = $self->Name =~ /^RT::CustomRole-(\d+)$/;
     +        if ($id) {
     +            my $role = RT::CustomRole->new($self->CurrentUser);
     +            $role->Load($id);
28:  5ac3fd7 = 28:  dd3759d @CustomRoles in initialdata, support CustomRole in @ACL
29:  09047b4 = 29:  1678043 Add custom roles to search builder
30:  978dd72 = 30:  ed0ff0c Ensure custom role name uniqueness in rt-validator