[Rt-commit] rt branch, 4.4/custom-roles, repushed

[Shawn Moore]

The branch 4.4/custom-roles was deleted and repushed:
       was 6c22fa9242076a6863b2e15d6839c51910ede898
       now c00c3a570c33ad7ba369356d735b9c0f5e5f4f63

 1:  3da168a =  1:  3da168a Tidy EmailInput and avoid including unescaped parameters
 2:  f4a3966 =  2:  f4a3966 Placeholder and EntryHint for EmailInput
 3:  5b777ea =  3:  5b777ea Support autocomplete-return for EmailInput
 4:  1168416 =  4:  1168416 Support for (by default, off) autocomplete of Nobody and System
 5:  87d20c2 =  5:  87d20c2 Only include one copy of "check box to delete" for queue watchers
 6:  7c59fae =  6:  7c59fae Simplify IsManageableRoleGroupType
 7:  78cbe3d =  7:  78cbe3d Switch several hardcoded lists to use ->Roles
 8:  8b8897b =  8:  8b8897b Avoid empty results and undef warnings in bulk update
 9:  89d776e =  9:  89d776e Tidy AddWatchers
10:  accaf5b = 10:  accaf5b Use the record we have for inspecting roles, rather than class RT::Queue
11:  3d5ba26 = 11:  3d5ba26 Add a CheckRight param to ->RoleGroup
12:  f467d55 = 12:  f467d55 Fix one-off "Administrative Cc" with "AdminCc"
13:  7cb01e5 = 13:  7cb01e5 Provide queue to EditBasics for new tickets (they don't have a ->QueueObj)
14:  71fc832 = 14:  71fc832 Provide defaults to EditBasics for "Add More Attach" etc
15:  4b1fd93 = 15:  4b1fd93 Factor out a CanonicalizePrincipal from AddRoleMember
16:  c7759ba = 16:  c7759ba Consistent error message across AddRoleMember and DeleteRoleMember
17:  ff898d8 = 17:  ff898d8 Factor out a _CreateRoleGroup
18:  6f0d646 = 18:  6f0d646 Lazily create ticket role groups if needed
19:  b2d8700 = 19:  b2d8700 Use queue to resolve roles on create since the ticket isn't created yet
20:  fe79a2f = 20:  fe79a2f Process watcher updates from ticket Modify
21:  e5dda97 = 21:  e5dda97 Improve messaging around updating queue/ticket watchers
22:  5539d9a = 22:  5539d9a Additional option for roles
23:  34bfce3 = 23:  34bfce3 Tidy watcher searching in RT::Tickets
24:  f0acbba = 24:  f0acbba Improve comments around GetPrincipalsMap
25:  cdf1d2e = 25:  cdf1d2e Add Ticket->RoleAddresses($Name)
26:  524f3d8 = 26:  524f3d8 Add a Group->Label hook for when we display a group's name in the UI
27:  baa947b = 27:  baa947b Switch to ->LabelForRole
28:  991f84a ! 28:  35cf1ab Add custom roles for queues
    @@ -1360,14 +1360,14 @@
      use RT::Interface::Web::Menu;
      use RT::Interface::Web::Session;
     @@
    - 
    -     ValidateWebConfig();
    +     InitializeMenu();
    +     MaybeShowInstallModePage();
      
     +    MaybeRebuildCustomRolesCache();
     +
    -     DecodeARGS($ARGS);
    -     local $HTML::Mason::Commands::DECODED_ARGS = $ARGS;
    -     PreprocessTimeUpdates($ARGS);
    +     $HTML::Mason::Commands::m->comp( '/Elements/SetupSessionCookie', %$ARGS );
    +     SendSessionCookie();
    + 
     @@
      
      }
29:  b35a81d = 29:  4d23e1c @CustomRoles in initialdata, support CustomRole in @ACL
30:  bb1cc0d = 30:  131cf55 Add custom roles to search builder
31:  6c22fa9 = 31:  c00c3a5 Ensure custom role name uniqueness in rt-validator