[Rt-commit] rt branch, 4.4/unify-search-visuals, created. rt-4.2.12-346-g115fe5d

Shawn Moore shawn at bestpractical.com
Wed Oct 28 16:45:24 EDT 2015 

The branch, 4.4/unify-search-visuals has been created
        at  115fe5d0db39de2f27ca3a21917267e8537e5f9e (commit)

- Log -----------------------------------------------------------------
commit d80623c561c5d31289da3bd2e0365fdfc7923622
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Oct 28 20:22:36 2015 +0000

    Stop reimplementing placeholder with onfocus for article quicksearch

diff --git a/share/html/Articles/Elements/GotoArticle b/share/html/Articles/Elements/GotoArticle
index dca5987..f1e4eb5 100644
--- a/share/html/Articles/Elements/GotoArticle
+++ b/share/html/Articles/Elements/GotoArticle
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <form ACTION="<% RT->Config->Get('WebPath') %>/Articles/Article/Search.html">
 <input type="hidden" name="HideOptions" value="1" />
-<input size="12" name="q" accesskey="0" value="<&|/l&>Search Articles</&>..." onfocus="if (this.value=='<&|/l&>Search Articles</&>...') this.value=''"  />
+<input size="12" name="q" accesskey="0" placeholder="<&|/l&>Search Articles</&>..." />
 % if ($class or $topic) {
 <input type="hidden" name="ExpandTopics" value="1" />
 <select name="Topics">

commit 24ef224e7cd30451a4aedc85af9b2234e17fabf4
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Oct 28 20:33:01 2015 +0000

    Unify ticket, asset, article topactions search UIs
    
        Fixes: I#31324

diff --git a/share/html/Articles/Elements/GotoArticle b/share/html/Articles/Elements/GotoArticle
index f1e4eb5..665df4f 100644
--- a/share/html/Articles/Elements/GotoArticle
+++ b/share/html/Articles/Elements/GotoArticle
@@ -45,9 +45,9 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<form ACTION="<% RT->Config->Get('WebPath') %>/Articles/Article/Search.html">
-<input type="hidden" name="HideOptions" value="1" />
-<input size="12" name="q" accesskey="0" placeholder="<&|/l&>Search Articles</&>..." />
+<form action="<% RT->Config->Get('WebPath') %>/Articles/Article/Search.html" class="article-search">
+  <input type="hidden" name="HideOptions" value="1" />
+  <input name="q" accesskey="0" class="field" placeholder="<&|/l&>Search Articles</&>..." type="search" results=5 autosave="search-articles" />
 % if ($class or $topic) {
 <input type="hidden" name="ExpandTopics" value="1" />
 <select name="Topics">
diff --git a/share/html/Asset/Elements/Search b/share/html/Asset/Elements/Search
index 09d131e..b29c4e7 100644
--- a/share/html/Asset/Elements/Search
+++ b/share/html/Asset/Elements/Search
@@ -45,8 +45,8 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<form ACTION="<% RT->Config->Get('WebPath') %>/Asset/Search/">
-  <input size="12" name="q" accesskey="0" class="field" value="<% $value %>" placeholder="<&|/l&>Search Assets</&>..." />
+<form action="<% RT->Config->Get('WebPath') %>/Asset/Search/" class="asset-search">
+  <input name="q" accesskey="0" class="field" value="<% $value %>" placeholder="<&|/l&>Search Assets</&>..." type="search" results=5 autosave="search-assets" />
 </form>
 <%init>
 my $value = defined $DECODED_ARGS->{q} ? $DECODED_ARGS->{q} : '';
diff --git a/share/html/Elements/SimpleSearch b/share/html/Elements/SimpleSearch
index 6d07a75..91446d9 100644
--- a/share/html/Elements/SimpleSearch
+++ b/share/html/Elements/SimpleSearch
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <form action="<% RT->Config->Get('WebPath') %><% $SendTo %>" id="simple-search">
-  <input size="12" name="q" accesskey="0" class="field" value="<% $value %>" placeholder="<% $Placeholder %>..." type="search" results=5 autosave="simple-search" />
+  <input name="q" accesskey="0" class="field" value="<% $value %>" placeholder="<% $Placeholder %>..." type="search" results=5 autosave="simple-search" />
 </form>
 <%init>
 my $value = defined $DECODED_ARGS->{q} ? $DECODED_ARGS->{q} : '';
diff --git a/share/static/css/aileron/nav.css b/share/static/css/aileron/nav.css
index 795ff6a..64ddee2 100644
--- a/share/static/css/aileron/nav.css
+++ b/share/static/css/aileron/nav.css
@@ -158,7 +158,7 @@
     -webkit-border-radius:  0 0 0 5px;
 }
 
-#simple-search input.field {
+#topactions input[type="search"] {
     border-radius: 3px;
     -moz-border-radius: 3px;
     -webkit-border-radius: 3px;
diff --git a/share/static/css/ballard/nav.css b/share/static/css/ballard/nav.css
index b2ec4b2..cfbb1b7 100644
--- a/share/static/css/ballard/nav.css
+++ b/share/static/css/ballard/nav.css
@@ -142,7 +142,7 @@
  color: #000;
  }
 
-#simple-search input.field {
+#topactions input[type="search"] {
     border-radius: 3px;
     -moz-border-radius: 3px;
     -webkit-border-radius: 3px;
diff --git a/share/static/css/base/nav.css b/share/static/css/base/nav.css
index e21b0f2..cb508f5 100644
--- a/share/static/css/base/nav.css
+++ b/share/static/css/base/nav.css
@@ -27,14 +27,14 @@
     width: 1.25em;
 }
 
-#simple-search input.field {
+#topactions input[type="search"] {
     border: none;
 
     /* turn off webkit input[type=search] styling */
     -webkit-appearance: textfield;
 }
 
-#simple-search input.field::-webkit-search-cancel-button {
+#topactions input[type="search"]::-webkit-search-cancel-button {
     /* hide webkit x button for searches */
     -webkit-appearance: none;
 }
diff --git a/share/static/css/rudder/nav.css b/share/static/css/rudder/nav.css
index ad48366..5340c27 100644
--- a/share/static/css/rudder/nav.css
+++ b/share/static/css/rudder/nav.css
@@ -147,7 +147,7 @@
     transition: width 0.25s ease-in-out;
 }
 
-#topactions #simple-search input:focus {
+#topactions input[type="search"]:focus {
     width: 16em;
     -webkit-transition: width 0.25s ease-in-out;
     -moz-transition: width 0.25s ease-in-out;
@@ -226,7 +226,7 @@
     -webkit-border-radius: 0 0 0 5px;
 }
 
-#simple-search input.field {
+#topactions input[type="search"] {
     border-radius: 3px;
     -moz-border-radius: 3px;
     -webkit-border-radius: 3px;

commit 115fe5d0db39de2f27ca3a21917267e8537e5f9e
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Oct 28 20:43:38 2015 +0000

    Have article and asset search always be double wide
    
        There's no "new ticket in" UI so the search box can be wider.
        Furthermore, the placeholder doesn't fit 8em.

diff --git a/share/static/css/aileron/nav.css b/share/static/css/aileron/nav.css
index 64ddee2..277187d 100644
--- a/share/static/css/aileron/nav.css
+++ b/share/static/css/aileron/nav.css
@@ -101,11 +101,15 @@
     vertical-align: top;
 }
 
-#topactions button, #topactions select, #topactions input{
+#topactions button, #topactions select, #topactions input {
  padding-top: 0em;
  padding-bottom: 0em;
  width: 8em;
+}
 
+#topactions .asset-search input,
+#topactions .article-search input {
+ width: 16em;
 }
 
 #topactions #simple-search .field{
diff --git a/share/static/css/ballard/nav.css b/share/static/css/ballard/nav.css
index cfbb1b7..a24f0a2 100644
--- a/share/static/css/ballard/nav.css
+++ b/share/static/css/ballard/nav.css
@@ -126,11 +126,15 @@
     vertical-align: top;
 }
 
-#topactions button, #topactions select, #topactions input{
+#topactions button, #topactions select, #topactions input {
  padding-top: 0em;
  padding-bottom: 0em;
  width: 8em;
+}
 
+#topactions .asset-search input,
+#topactions .article-search input {
+ width: 16em;
 }
 
 #topactions #simple-search .field{
diff --git a/share/static/css/rudder/nav.css b/share/static/css/rudder/nav.css
index 5340c27..a4eca78 100644
--- a/share/static/css/rudder/nav.css
+++ b/share/static/css/rudder/nav.css
@@ -147,6 +147,12 @@
     transition: width 0.25s ease-in-out;
 }
 
+#topactions .asset-search input[type="search"],
+#topactions .article-search input[type="search"]
+ {
+    width: 16em;
+}
+
 #topactions input[type="search"]:focus {
     width: 16em;
     -webkit-transition: width 0.25s ease-in-out;

-----------------------------------------------------------------------

More information about the rt-commit mailing list