[Rt-commit] rt branch, 4.4/ticket-history-page-optional-param, created. rt-4.2.12-377-g9296964

[Dustin Graves]

The branch, 4.4/ticket-history-page-optional-param has been created
        at  929696469a7abcbf42aacb014feedda7a5b9524e (commit)

- Log -----------------------------------------------------------------
commit 929696469a7abcbf42aacb014feedda7a5b9524e
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Fri Oct 30 19:35:00 2015 +0000

    change $oldestTransactionsFirst to optional parameter on TicketHistoryPage

diff --git a/share/html/Helpers/TicketHistoryPage b/share/html/Helpers/TicketHistoryPage
index d449966..19cb2d0 100644
--- a/share/html/Helpers/TicketHistoryPage
+++ b/share/html/Helpers/TicketHistoryPage
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <%ARGS>
 $id
-$oldestTransactionsFirst
+$oldestTransactionsFirst => RT->Config->Get("OldestTransactionsFirst", $session{CurrentUser});
 $lastTransactionId => undef
 $focusTransactionId => undef
 </%ARGS>
diff --git a/share/html/Ticket/Elements/ScrollShowHistory b/share/html/Ticket/Elements/ScrollShowHistory
index 3fcdc2e..31e6563 100644
--- a/share/html/Ticket/Elements/ScrollShowHistory
+++ b/share/html/Ticket/Elements/ScrollShowHistory
@@ -62,8 +62,6 @@ $m->callback( CallbackName => 'ExtraShowHistoryArguments', Ticket => $Ticket, Ex
 my $ShowDisplayModes = 1 || $extra_args{'ShowDisplayModes'};
 my $ShowTitle =        1 || $extra_args{'ShowTitle'};
 my $ShowHeaders =      0 || $extra_args{'ShowHeaders'};
-
-my $oldestTransactionsFirst = RT->Config->Get("OldestTransactionsFirst", $session{CurrentUser});
 </%INIT>
 
 <& /Elements/ShowHistoryHeader,
@@ -88,8 +86,6 @@ jQuery(function(){
         hash = window.location.hash,
         hashTransactionId = null;
 
-    var oldestTransactionsFirst = <% $oldestTransactionsFirst || 0 %>;
-
     var removeLoadingMessage = function() {
         jQuery('.loading-message').remove();
     };
@@ -118,7 +114,7 @@ jQuery(function(){
         isLoading = true;
         showLoadingMessage();
 
-        var queryString = '&oldestTransactionsFirst=' + oldestTransactionsFirst;
+        var queryString = '';
         if (lastTransactionId) queryString += '&lastTransactionId=' + lastTransactionId;
 
         // check for link to specific transaction and make sure we load enough to focus it

-----------------------------------------------------------------------