[Rt-commit] rt branch, master, updated. rt-4.2.11-203-g6f104f0

Shawn Moore shawn at bestpractical.com
Mon Sep 28 21:07:12 EDT 2015


The branch, master has been updated
       via  6f104f01d3d028e43096023dd46dbfbe65ad9347 (commit)
      from  5e937f681cb79480c585dd11dea7ecd2d110e3dd (commit)

Summary of changes:
 lib/RT/Test/Web.pm  | 5 +++++
 t/mail/dashboards.t | 1 +
 t/web/cf_date.t     | 1 +
 3 files changed, 7 insertions(+)

- Log -----------------------------------------------------------------
commit 6f104f01d3d028e43096023dd46dbfbe65ad9347
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Fri Aug 7 18:57:30 2015 +0000

    explain that RT::Test::Web must be destroyed before done_testing

diff --git a/lib/RT/Test/Web.pm b/lib/RT/Test/Web.pm
index 718744d..46cdc05 100644
--- a/lib/RT/Test/Web.pm
+++ b/lib/RT/Test/Web.pm
@@ -434,6 +434,11 @@ sub dom {
 
 sub DESTROY {
     my $self = shift;
+
+    if ( RT::Test->builder->{Done_Testing} ) {
+        die "RT::Test::Web object needs to be destroyed before done_testing is called";
+    }
+
     if ( !$RT::Test::Web::DESTROY++ ) {
         $self->no_warnings_ok;
     }
diff --git a/t/mail/dashboards.t b/t/mail/dashboards.t
index d7b1ccc..18cfd58 100644
--- a/t/mail/dashboards.t
+++ b/t/mail/dashboards.t
@@ -363,4 +363,5 @@ produces_no_dashboard_mail_ok(
     Time    => $bad_time,
 );
 
+undef $m;
 done_testing;
diff --git a/t/web/cf_date.t b/t/web/cf_date.t
index b3b7dcc..1e890c3 100644
--- a/t/web/cf_date.t
+++ b/t/web/cf_date.t
@@ -279,4 +279,5 @@ diag 'retain values when adding attachments';
         "2015-12-16", "txn date value still on form" );
 }
 
+undef $m;
 done_testing;

-----------------------------------------------------------------------


More information about the rt-commit mailing list