[Rt-commit] rt branch, 4.4-trunk, updated. rt-4.4.0-82-gf1f76c7

Shawn Moore shawn at bestpractical.com
Fri Apr 22 13:17:29 EDT 2016


The branch, 4.4-trunk has been updated
       via  f1f76c728fc56d8aea45c0ad3dec0f1da461551a (commit)
      from  4b8e2b5111bdaedb2108883ad95f4752bb4b568c (commit)

Summary of changes:
 share/html/Helpers/PreviewScrips | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit f1f76c728fc56d8aea45c0ad3dec0f1da461551a
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Fri Apr 22 17:13:25 2016 +0000

    Consistently use $addr->address to avoid overloading error
    
        Using $addr directly exposes a bug with older versions of Email::Address
        since that module started using fallback string overloading only in
        version 1.899, while the minimum version we require is 1.897.
    
        The rest of the code, even when it was initially added as
        098c568fea06a7138cc8ef8e6e377ce27fbbc72f uses $addr->address, so this
        improves consistency while also fixing the bug.
    
    Fixes: I#31712

diff --git a/share/html/Helpers/PreviewScrips b/share/html/Helpers/PreviewScrips
index b44e9fc..0aa65b9 100644
--- a/share/html/Helpers/PreviewScrips
+++ b/share/html/Helpers/PreviewScrips
@@ -112,7 +112,7 @@ $submitted{$_} = 1 for split /,/, $ARGS{TxnRecipients};
 %                 $recips{$addr->address}++;
                   <b><%loc($type)%></b>:
 %                 my $show_checkbox = 1;
-%                 if ( grep {$_ eq $addr} @{$action->{NoSquelch}{$type}} ) {
+%                 if ( grep {$_ eq $addr->address} @{$action->{NoSquelch}{$type}} ) {
 %                     $show_checkbox = 0;
 %                 }
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list