[Rt-commit] rt branch, 4.4/inline-edit, created. rt-4.4.1-109-g74c6ea0

Shawn Moore shawn at bestpractical.com
Thu Aug 25 10:37:36 EDT 2016


The branch, 4.4/inline-edit has been created
        at  74c6ea0f9adcf8cfcc1f5d8de5849bf7abe55a0c (commit)

- Log -----------------------------------------------------------------
commit fef4c5d699d05f7f4539ee7de34c74a2f1fd7ac1
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Jul 21 11:13:54 2016 -0400

    Add a webpath option to rt-server
    
    Add --webpath to the rt-server test server to allow
    running the server and testing at /rt.

diff --git a/lib/RT/PlackRunner.pm b/lib/RT/PlackRunner.pm
index e30f4bd..e0a97de 100644
--- a/lib/RT/PlackRunner.pm
+++ b/lib/RT/PlackRunner.pm
@@ -73,6 +73,8 @@ sub parse_options {
     $self->{server} ||= $self->loader->guess;
 
     my %args = @{$self->{options}};
+    $self->{webpath} ||= $args{webpath} if $args{webpath};
+
     if ($self->{server} eq "FCGI") {
         # We deal with the possible failure modes of this in ->run
     } elsif ($args{port}) {
@@ -138,6 +140,13 @@ sub run {
         exit 1;
     }
 
+    if ( $self->{webpath} ){
+        require Plack::App::URLMap;
+        my $urlmap = Plack::App::URLMap->new;
+        $urlmap->map($self->{webpath} => $self->{app});
+        $self->{app} = $urlmap->to_app;
+    }
+
     eval { $self->SUPER::run(@_) };
     my $err = $@;
     exit 0 unless $err;
diff --git a/sbin/rt-server.in b/sbin/rt-server.in
index fb4aed9..7df8625 100644
--- a/sbin/rt-server.in
+++ b/sbin/rt-server.in
@@ -172,6 +172,9 @@ rt-server - RT standalone server
     # runs prefork server listening on port 8080, requires Starlet
     rt-server --port 8080
 
+    # runs prefork server listening on port 8080 at /rt
+    rt-server --port 8080 --webpath /rt
+
     # runs server listening on port 8080
     rt-server --server Standalone --port 8080
     # or

commit 5f4c8a2e4311ade309d109cb59682fa8ac0c3f6d
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Thu Aug 11 22:33:02 2016 +0000

    add config option HideOneTimeSuggestions to hide one-time Cc and Bcc email addresses
    
    this encapsulates the list of email addresses in a toggleable div with
    (show suggestions) and (hide suggestions) links
    
    Fixes: T#168228

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 705c6c9..4627f22 100644
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -3864,8 +3864,24 @@ Admin -> Tools menu for SuperUsers.
 
 Set($StatementLog, undef);
 
+=item C<$HideOneTimeSuggestions>
+
+On ticket comment and correspond there are "One-time Cc" and "One-time Bcc"
+fields. As part of this section, RT includes a list of suggested email
+addresses based on the correspondence history for that ticket. This list may
+grow quite large over time.
+
+Enabling this option will hide the list behind a "(show suggestions)" link to
+cut down on page clutter. Once this option is clicked the link will change to
+"(hide suggestions)" and the full list of email addresses will be shown.
+
+=cut
+
+Set($HideOneTimeSuggestions, 0);
+
 =back
 
+
 =cut
 
 1;
diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index c7d2637..641fa33 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -52,6 +52,12 @@
         <br />
 
 %if (scalar @one_time_Ccs) {
+%   if ($hide_cc_suggestions) {
+        <a href="#" class="ToggleSuggestions" data-hide-label="<% $hide_label %>" data-show-label="<% $show_label %>">
+            <i class="label">(<&|/l&>show suggestions</&>)</i>
+        </a>
+        <div class="OneTimeCcs hidden">
+%   }
 <i class="label">(<&|/l&>check to add</&>)</i>
 %}
 %foreach my $addr ( @one_time_Ccs ) {
@@ -65,9 +71,18 @@
     <% $ARGS{'UpdateCc-'.$addr} ? 'checked="checked"' : ''%> >
       <label for="UpdateCc-<%$addr%>"><& /Elements/ShowUser, Address => $txn_addresses{$addr}&></label>
 %}
+%if (@one_time_Ccs && $hide_cc_suggestions) {
+</div>
+%}
 </td></tr>
 <tr><td class="label"><&|/l&>One-time Bcc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateBcc', Size => undef, Default => $ARGS{UpdateBcc}, AutocompleteMultiple => 1 &><br />
 %if (scalar @one_time_Ccs) {
+%   if ($hide_cc_suggestions) {
+        <a href="#" class="ToggleSuggestions" data-hide-label="<% $hide_label %>" data-show-label="<% $show_label %>">
+            <i class="label">(<&|/l&>show suggestions</&>)</i>
+        </a>
+        <div class="OneTimeCcs hidden">
+%   }
 <i class="label">(<&|/l&>check to add</&>)</i>
 %}
 %foreach my $addr ( @one_time_Ccs ) {
@@ -81,6 +96,21 @@
     <% $ARGS{'UpdateBcc-'.$addr} ? 'checked="checked"' : ''%> >
       <label for="UpdateBcc-<%$addr%>"><& /Elements/ShowUser, Address => $txn_addresses{$addr}&></label>
 %}
+%if (@one_time_Ccs && $hide_cc_suggestions) {
+</div>
+<script type="text/javascript">
+jQuery(function() {
+    jQuery('a.ToggleSuggestions').click(function(e) {
+        e.preventDefault();
+        var toggleSuggestions = jQuery(this);
+        var oneTimeCcs = toggleSuggestions.closest('td').find('.OneTimeCcs');
+        oneTimeCcs.toggleClass('hidden');
+        var hideOrShow = oneTimeCcs.hasClass('hidden') ? toggleSuggestions.data('showLabel') : toggleSuggestions.data('hideLabel');
+        toggleSuggestions.find('i').html('(' + hideOrShow + ')');
+    });
+});
+</script>
+%}
 </td></tr>
 <%args>
 $TicketObj
@@ -100,4 +130,8 @@ foreach my $addr ( keys %txn_addresses) {
   next if ( grep {$addr eq lc $_->address} @people_addresses );
   push @one_time_Ccs,$addr;
 }
+
+my $hide_cc_suggestions =  RT->Config->Get('HideOneTimeSuggestions', $session{CurrentUser});
+my $show_label    = $m->interp->apply_escapes( loc("show suggestions"), 'h' );
+my $hide_label    = $m->interp->apply_escapes( loc("hide suggestions"), 'h' );
 </%init>

commit ad59123af04971e43f13da0de457db65d63b5429
Merge: 6df28d5 5f4c8a2
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Fri Aug 19 21:14:32 2016 +0000

    Merge branch '4.4/hide-onetime-cc-suggestions' into 4.4-trunk


commit fc7fd6b4eefaccd4550d9869da149ea3ee1d5e90
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Tue Aug 9 23:11:24 2016 +0000

    add 'All recipients' checkbox to ModifyPeople.html similar to the one on Update.html
    
    this checkbox will check/uncheck all of the individual recipient checkboxes
    
    Fixes: T#168226

diff --git a/share/html/Ticket/ModifyPeople.html b/share/html/Ticket/ModifyPeople.html
index bb02e6e..08bee71 100644
--- a/share/html/Ticket/ModifyPeople.html
+++ b/share/html/Ticket/ModifyPeople.html
@@ -63,6 +63,12 @@
 <&|/l&>The checked users may receive email related to this ticket depending on the action taken. Uncheck users to stop sending email to them about this ticket.</&>
 </p>
 
+<%PERL>
+my $all_recipients_checked = (grep { !$_ } values %recips) ? 0 : 1;
+</%PERL>
+<input type="checkbox" class="checkbox" id="TxnSendMailToAll" onclick="setCheckbox(this, 'checked_recipient')" <% $all_recipients_checked ? 'checked' : '' %>>
+<label for="TxnSendMailToAll"><b><% loc('All recipients') %></b></label><br />
+
 <ul>
 % for my $addr (sort keys %recips) {
   <li>

commit 148773b084f567555559249e1fad67330ce0132b
Merge: ad59123 fef4c5d
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Mon Aug 22 22:37:15 2016 +0000

    Merge branch '4.4/rt-server-webpath' into 4.4-trunk


commit 74c6ea0f9adcf8cfcc1f5d8de5849bf7abe55a0c
Merge: 148773b fc7fd6b
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Aug 24 16:50:15 2016 +0000

    Merge branch '4.4/modify-people-squelch-all-checkbox' into 4.4-trunk


-----------------------------------------------------------------------


More information about the rt-commit mailing list