[Rt-commit] [rtir] 01/01: Use RT::IR->lifecycle_* methods instead of hardcoding

Shawn Moore shawn at bestpractical.com
Wed Feb 24 17:39:05 EST 2016


This is an automated email from the git hooks/post-receive script.

shawn pushed a commit to branch 3.4/countermeasures
in repository rtir.

commit af89baa5174d6a45a1a7f94753d302098c6545aa
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Feb 24 22:38:46 2016 +0000

    Use RT::IR->lifecycle_* methods instead of hardcoding
---
 bin/add_constituency.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bin/add_constituency.in b/bin/add_constituency.in
index 6215b7e..d3757b4 100755
--- a/bin/add_constituency.in
+++ b/bin/add_constituency.in
@@ -293,16 +293,16 @@ sub grant_role_queue_rights {
         debug "Granting role rights to Everyone for queue " . $queue->Name . "\n";
         my @rights;
 
-        if ( $queue->Lifecycle eq 'incident_reports' ) {
+        if ( $queue->Lifecycle eq RT::IR->lifecycle_report ) {
             @rights = RT::IR->EveryoneIncidentReportRights();
-        } elsif ( $queue->Lifecycle eq 'incidents' ) {
+        } elsif ( $queue->Lifecycle eq RT::IR->lifecycle_incident ) {
             @rights = RT::IR->EveryoneIncidentRights();
 
         }
-        if ( $queue->Lifecycle eq 'investigations' ) {
+        if ( $queue->Lifecycle eq RT::IR->lifecycle_investigation ) {
             @rights = RT::IR->EveryoneInvestigationRights();
 
-        } elsif ( $queue->Lifecycle eq 'countermeaures' ) {
+        } elsif ( $queue->Lifecycle eq RT::IR->lifecycle_countermeasure ) {
             @rights = RT::IR->EveryoneBlockRights();
         }
         # grant 'everyone' rights

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list