[Rt-commit] rtir branch, 4.0/fix-history-scroll, created. 4.0.0rc1-10-g28c552c

Dustin Graves dustin at bestpractical.com
Fri Jul 1 17:14:57 EDT 2016


The branch, 4.0/fix-history-scroll has been created
        at  28c552c955a923cab28342b6e97a5647d3a73fe3 (commit)

- Log -----------------------------------------------------------------
commit 28c552c955a923cab28342b6e97a5647d3a73fe3
Author: Dustin Graves <dustin at bestpractical.com>
Date:   Fri Jul 1 21:01:32 2016 +0000

    add support for 'as you scroll' ticket history option
    
    previously there was no logic in place and it would fall back to
    'immediately' option
    
    this adds the logic in Display.html and Incident/Display.html as well as
    adding a symbolic link to the ExtraShowHistoryArguments callback for
    the ShowHistoryPage helper

diff --git a/html/Callbacks/RTIR/Helpers/TicketHistoryPage/ExtraShowHistoryArguments b/html/Callbacks/RTIR/Helpers/TicketHistoryPage/ExtraShowHistoryArguments
new file mode 120000
index 0000000..9180400
--- /dev/null
+++ b/html/Callbacks/RTIR/Helpers/TicketHistoryPage/ExtraShowHistoryArguments
@@ -0,0 +1 @@
+html/Callbacks/RTIR/Helpers/TicketHistory/ExtraShowHistoryArguments
\ No newline at end of file
diff --git a/html/RTIR/Display.html b/html/RTIR/Display.html
index fdf26f4..ddd384e 100644
--- a/html/RTIR/Display.html
+++ b/html/RTIR/Display.html
@@ -140,7 +140,11 @@
 </&></div>
 
 % my $ShowHistory = RT->Config->Get("ShowHistory", $session{'CurrentUser'});
-% if ($ShowHistory eq "delay") {
+% if ($ShowHistory eq "scroll") {
+    <& /Ticket/Elements/ScrollShowHistory,
+        Ticket => $TicketObj
+    &>
+% } elsif ($ShowHistory eq "delay") {
     <& /Ticket/Elements/DelayShowHistory,
         Ticket => $Ticket,
         ShowHeaders => $ARGS{'ShowHeaders'},
diff --git a/html/RTIR/Incident/Display.html b/html/RTIR/Incident/Display.html
index 461436f..9c823fd 100644
--- a/html/RTIR/Incident/Display.html
+++ b/html/RTIR/Incident/Display.html
@@ -143,7 +143,11 @@
 </&></div>
 
 % my $ShowHistory = RT->Config->Get("ShowHistory", $session{'CurrentUser'});
-% if ($ShowHistory eq "delay") {
+% if ($ShowHistory eq "scroll") {
+    <& /Ticket/Elements/ScrollShowHistory,
+        Ticket => $TicketObj
+    &>
+% } elsif ($ShowHistory eq "delay") {
     <& /Ticket/Elements/DelayShowHistory,
         Ticket => $TicketObj,
         ShowHeaders => $ARGS{'ShowHeaders'},

-----------------------------------------------------------------------


More information about the rt-commit mailing list