[Rt-commit] rt branch, 4.4/dependencies, repushed

[Alex Vandiver]

The branch 4.4/dependencies was deleted and repushed:
       was fa5cf0c2906b55926c4185cad8345b744d6c2f1b
       now 6902fdd098b16a927213f220e7d7d18fef67f6e8

 1:  c34edac =  1:  c34edac Remove duplicate Encode dependency
 2:  0c3a310 =  2:  0c3a310 Sort LWP::Simple correctly
 3:  4c1f1d3 =  3:  4c1f1d3 Remove unnecessary FCGI::ProcManager dependency
 4:  c7bdc53 =  4:  c7bdc53 Fold in core dependencies that cannot be disabled
 5:  7ceaef0 =  5:  7ceaef0 Fold in --with-html-doc into developer dependencies
 6:  afe83f8 =  6:  afe83f8 Only add the externalauth test dependency for developers
 7:  0cf3a9c =  7:  0cf3a9c Remove the last vestiges of --download
 8:  8587c63 =  8:  8587c63 Improve documentation
 9:  7fe4525 =  9:  7fe4525 Move functions down
10:  8ac5f66 = 10:  8ac5f66 perltidy
11:  41f950a = 11:  41f950a Make --verbose a no-op; it is always passed by the makefile
12:  db052ad = 12:  db052ad Remove --list-deps; it is undocumented and unuseful
13:  af82044 = 13:  af82044 Refactor, reword, and reorder CPAN checking
14:  e723434 ! 14:  072a988 Store dependencies in cpanfile
    @@ -497,7 +497,6 @@
     -    $type = $1;
     -    section("$type dependencies");
     +if ($args{'install'}) {
    -+    my $missing = 0;
     +    for my $type ( sort keys %deps ) {
     +        for my $module (sort keys %{$deps{$type}}) {
     +            # Recheck if the dependency is now satisfied, either
    @@ -529,12 +528,13 @@
     -                if test_dep( $module, $missing{$module}{version}, $AVOID{$module} );
     +
     +            # Recheck, to catch install failures and the like
    -+            $missing++ unless test_dep( $module, $deps{$type}{$module} );
    ++            delete $deps{$type}{$module} if test_dep( $module, $deps{$type}{$module} );
              }
    ++        delete $deps{$type} if not keys %{$deps{$type}};
          }
     -
     -    $Missing_By_Type{$type} = \%missing if keys %missing;
    -+    exec( $script_path, @orig_argv, '--no-install' ) if $missing;
    ++    exec( $script_path, @orig_argv, '--no-install' ) if %deps;
      }
      
     -if ( $args{'install'} && keys %Missing_By_Type ) {
15:  471a74a = 15:  86c9cc6 Move perl version into cpanfile
16:  cb7e7ca = 16:  e1e4c14 Rename print_found to row
17:  64e44b8 = 17:  5f4dd27 Improve horizontal and vertical spacing of output
18:  d8b1134 = 18:  90cefa6 Show current version of module, when relevant
19:  c4c5821 = 19:  deadd64 Use "current value" for perl check as well
20:  238844d = 20:  ae0dbc3 Use "current value" for user / group display
21:  666752d = 21:  278b161 Rename, since it checks groups as well as users
22:  9e64922 = 22:  fd0db29 Fail-fast if the users or groups do not check out
23:  4d7e678 = 23:  e8fb26d Show output with colors when run from a terminal
24:  fa5cf0c = 24:  6902fdd Move database and deployment defaults into rt-test-dependencies