[Rt-commit] rt branch, 4.2/migrator-fixes, repushed

[Shawn Moore]

The branch 4.2/migrator-fixes was deleted and repushed:
       was 52c4ac365738d709e68673284bd5d1a5faa90df3
       now 37e7c98e37f7ad7ac6ad8983fbc3c4702211d23d

 1:  50dea85 =  1:  50dea85 add AddRight calls to 4.0.1 upgrade step to prevent error message due to failure to canonicalize rights
 2:  3b8ae5b =  2:  3b8ae5b Update detection of find version in configure
 3:  1cac7d3 =  3:  1cac7d3 Serialize ObjectClass ObjectId using indirection
 4:  06c4c43 =  4:  a8bf0f3 Serialize ObjectScrip ObjectId using indirection
 5:  152c90c =  5:  a8b281e Serialize ObjectTopic ObjectId using indirection
 6:  84b0222 =  6:  aea531f Avoid breaking rights granted to users when using rt-importer
 7:  5c2cdac =  7:  037839b Serialize dashboards in menu preference using indirection
 8:  69ab543 !  8:  1e9287a Add a way to register a postpone callback in importer
    @@ -2,7 +2,8 @@
     
         Add a way to register a postpone callback in importer
         
    -        This is meant for inflating saved searches and dashboards (see followup commits)
    +        This is meant for inflating saved searches and dashboards (see followup
    +        commits)
     
     diff --git a/lib/RT/Migrate/Importer.pm b/lib/RT/Migrate/Importer.pm
     --- a/lib/RT/Migrate/Importer.pm
 9:  97cf209 =  9:  7d6f9d6 Don't skip importing RT->System searches
10:  f464c3f = 10:  0a408ad Serialize RT at a Glance preferences using indirection
11:  f05b668 ! 11:  fce4f08 Serialize dashboards using indirection
    @@ -2,8 +2,9 @@
     
         Serialize dashboards using indirection
         
    -        Otherwise the old search and dashboard IDs will be kept in the component
    -        list, causing the dashboard to render with "search not found" type errors.
    +        Otherwise the old search and dashboard IDs will be kept in the
    +        component list, causing the dashboard to render with "search not
    +        found" type errors.
         
         Fixes: I#31808
     
12:  1240499 ! 12:  5d01baa Serialize dashboard subscriptions using indirection
    @@ -12,7 +12,7 @@
                  }
              }
          }
    -+    # subscriptions have dependencies their dashboard
    ++    # each subscription depends on its dashboard
     +    elsif ($self->Name eq 'Subscription') {
     +        my $content = $self->Content;
     +        my $attr = RT::Attribute->new($self->CurrentUser);
13:  cd06315 ! 13:  330623d --exclude-organization option for rt-importer
    @@ -103,6 +103,20 @@
      
      if ($import->Metadata and -t STDOUT and not $OPT{quiet}) {
     @@
    + It is possible to stop the import process with ^C; it can be later
    + resumed by re-running the importer.
    + 
    ++Certain records (notably queues and groups) will have their original
    ++Organization name prepended to them on import. This is primarily to avoid
    ++duplicate names (for example importing a General queue into an RT that
    ++already has one would otherwise cause a name collision error). You may
    ++suppress this behavior by passing the B<--exclude-organization> flag to
    ++C<rt-importer>.
    ++
    + =head2 OPTIONS
    + 
    + =over
    +@@
      field with the given name.  If no global ticket custom field with that
      name is found in the current database, it will create one.
      
14:  52c4ac3 ! 14:  37e7c98 Serialize Transaction OldReference and NewReference using indirection
    @@ -1,6 +1,10 @@
     Author: Shawn M Moore <shawn at bestpractical.com>
     
    -    Correctly serialize reference from Txn to OCFV for Type=CustomField
    +    Serialize Transaction OldReference and NewReference using indirection
    +    
    +        Otherwise each transaction which records a custom field update would
    +        point to the wrong ObjectCustomFieldValue records, causing RT to
    +        display incorrect old and new values in, especially, ticket history.
     
     diff --git a/lib/RT/Transaction.pm b/lib/RT/Transaction.pm
     --- a/lib/RT/Transaction.pm