[Rt-commit] rt branch, 4.2/migrator-fixes, repushed

[Shawn Moore]

The branch 4.2/migrator-fixes was deleted and repushed:
       was 3a2fb8e90e57f7447a33e327e3c8aa63b58e59f4
       now 84b02228763304a20edec35cc8547aa9e9c99862

1:  50dea85 = 1:  50dea85 add AddRight calls to 4.0.1 upgrade step to prevent error message due to failure to canonicalize rights
2:  3b8ae5b = 2:  3b8ae5b Update detection of find version in configure
3:  1cac7d3 = 3:  1cac7d3 Serialize ObjectClass ObjectId using indirection
4:  06c4c43 = 4:  06c4c43 Serialize ObjectScrip ObjectId using indirection
5:  152c90c = 5:  152c90c Serialize ObjectTopic ObjectId using indirection
6:  3a2fb8e ! 6:  84b0222 Avoid breaking rights granted to users when using rt-importer
    @@ -1,21 +1,21 @@
     Author: Shawn M Moore <shawn at bestpractical.com>
     
    -    Fix for importing ACLs granted to users
    +    Avoid breaking rights granted to users when using rt-importer
         
    -        Before this fix, importing ACLs from another system correctly
    -        maintained rights granted to groups, but not those granted to
    -        users. This is because when we inflate the ACLEquivalence
    -        UserEquiv group for that user, we change its name to handle the
    -        change in the user's ID.
    +        The "user rights" admin pages issue a SQL query where each
    +        user's ACLEquivalence group name is expected to be "UserEquiv".
    +        However, before this commit, the importer system changed each
    +        group's name from the expected "UserEquiv" to be e.g. "User 99",
    +        since the user ID changes during import. So because the group
    +        name was no longer "UserEquiv", the admin UI was failing to find
    +        the existant but malformed ACL entries.
         
    -        However, ACLEquivalence UserEquiv groups have not used user ID
    -        in their name since 71fcde32, which is when this regression was
    -        introduced.
    -    
    -        The admin pages for user rights issue a query where
    -        the ACLEquivalence group name is expected to be "UserEquiv" but
    -        the importer code was changing the name from UserEquiv to be
    -        e.g. "User 99". So it wasn't finding or listing the ACL entries.
    +        ACLEquivalence UserEquiv groups stopped using the user's ID in
    +        their name as of 71fcde32, which is exactly when this regression
    +        was introduced. Previously, user rights importing worked because
    +        both the migrator and the ACL subsytems correctly used the Type
    +        of the group, which was "UserEquiv". (The regression was
    +        introduced because ACLs started using Name in place of Type)
         
         Fixes: I#31806