[Rt-commit] rt branch, 4.4/links-table-layout, created. rt-4.4.0-83-gff38432

Shawn Moore shawn at bestpractical.com
Mon May 2 15:50:46 EDT 2016


The branch, 4.4/links-table-layout has been created
        at  ff384323ad57a796806688223da9fc745e1aec2d (commit)

- Log -----------------------------------------------------------------
commit ff384323ad57a796806688223da9fc745e1aec2d
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Mon May 2 19:49:19 2016 +0000

    Move create-related-ticket-in-queue form out of the table
    
        Browsers render this poorly when there are no existant links.
    
    Fixes: I#31871

diff --git a/share/html/Elements/ShowLinks b/share/html/Elements/ShowLinks
index e7ab61d..8558bd9 100644
--- a/share/html/Elements/ShowLinks
+++ b/share/html/Elements/ShowLinks
@@ -65,27 +65,24 @@
 % $m->callback( %ARGS );
   <& /Elements/ShowCustomFields, Object => $Object, Grouping => 'Links', Table => 0 &>
 
+</table>
+
 % if ($Object->isa('RT::Ticket')) {
-  <tr>
-    <td colspan=2>
-      <form action="<% RT->Config->Get('WebPath') ."/Helpers/SpawnLinkedTicket" %>" name="SpawnLinkedTicket">
-        <input type="hidden" name="CloneTicket" value="<% $Object->id %>">
-        <input type="submit" value="<&|/l&>Create</&>" name="SpawnLinkedTicket">
-        <select name="LinkType">
-          <option value="DependsOn-new"><% loc('Depends on') %></option>
-          <option value="new-DependsOn"><% loc('Depended on by') %></option>
-          <option value="MemberOf-new"><% loc('Parents') %></option>
-          <option value="new-MemberOf"><% loc('Children') %></option>
-          <option value="RefersTo-new"><% loc('Refers to') %></option>
-          <option value="new-RefersTo"><% loc('Referred to by') %></option>
-        </select>
-        <&|/l&>Ticket in</&>
-        <& /Elements/SelectQueue, ShowNullOption => 0, Name => 'CloneQueue' &>
-      </form>
-    </td>
-  </tr>
+  <form action="<% RT->Config->Get('WebPath') ."/Helpers/SpawnLinkedTicket" %>" name="SpawnLinkedTicket">
+    <input type="hidden" name="CloneTicket" value="<% $Object->id %>">
+    <input type="submit" value="<&|/l&>Create</&>" name="SpawnLinkedTicket">
+    <select name="LinkType">
+      <option value="DependsOn-new"><% loc('Depends on') %></option>
+      <option value="new-DependsOn"><% loc('Depended on by') %></option>
+      <option value="MemberOf-new"><% loc('Parents') %></option>
+      <option value="new-MemberOf"><% loc('Children') %></option>
+      <option value="RefersTo-new"><% loc('Refers to') %></option>
+      <option value="new-RefersTo"><% loc('Referred to by') %></option>
+    </select>
+    <&|/l&>Ticket in</&>
+    <& /Elements/SelectQueue, ShowNullOption => 0, Name => 'CloneQueue' &>
+  </form>
 % }
-</table>
 <%INIT>
 my @display = qw(DependsOn DependedOnBy MemberOf Members RefersTo ReferredToBy);
 $m->callback( %ARGS, CallbackName => 'ChangeDisplay', display => \@display );

-----------------------------------------------------------------------


More information about the rt-commit mailing list