[Rt-commit] rt branch, 4.4/filter-one-time-email-addresses, created. rt-4.4.0-72-g6b87762

Jim Brandt jbrandt at bestpractical.com
Thu May 12 11:45:07 EDT 2016


The branch, 4.4/filter-one-time-email-addresses has been created
        at  6b877623854cee199a61826f868b3ac730fd30e1 (commit)

- Log -----------------------------------------------------------------
commit 6b877623854cee199a61826f868b3ac730fd30e1
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu May 12 11:41:59 2016 -0400

    Filter all watcher addresses from one-time suggestions on update
    
    If email addresses previously seen on a ticket have been added
    in People as a watcher, either Requestor, Cc, or AdminCc,
    we no longer need to show them as a options for one-time Cc
    because they will get email by virtue of being a watcher.

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index ec241f9..c7d2637 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -87,11 +87,17 @@ $TicketObj
 </%args>
 <%init>
 my %txn_addresses = %{$TicketObj->TransactionAddresses};
-my @req_addresses = Email::Address->parse( $TicketObj->RequestorAddresses );
+
+# Get people already added as watchers on the ticket so we can filter
+# them out of the one-time list
+my @people_addresses = Email::Address->parse( $TicketObj->RequestorAddresses );
+push @people_addresses, Email::Address->parse( $TicketObj->CcAddresses );
+push @people_addresses, Email::Address->parse( $TicketObj->AdminCcAddresses );
+
 my @one_time_Ccs;
 
 foreach my $addr ( keys %txn_addresses) {
-  next if ( grep {$addr eq lc $_->address} @req_addresses );
+  next if ( grep {$addr eq lc $_->address} @people_addresses );
   push @one_time_Ccs,$addr;
 }
 </%init>

-----------------------------------------------------------------------


More information about the rt-commit mailing list