[Rt-commit] rt branch, 4.4/html-attachment-escaping, created. rt-4.4.0-116-g27d9356

[Rachel Kelly]

The branch, 4.4/html-attachment-escaping has been created
        at  27d935639ac5507c891464770c96050151e27bd9 (commit)

- Log -----------------------------------------------------------------
commit 27d935639ac5507c891464770c96050151e27bd9
Author: rachelkelly <rachel at bestpractical.com>
Date:   Thu May 5 13:27:19 2016 +0000

    Remove url-escaping character from attachment name parsing
    
        Attachments in ticket replies and comments are parsed incorrectly
        if they contain an ampersand.  Removed url escaping in the
        displaying function of the attachment name.
    
    Fixed: #I31751

diff --git a/share/html/Elements/ShowTransactionAttachments b/share/html/Elements/ShowTransactionAttachments
index d9aa8ba..22f84c7 100644
--- a/share/html/Elements/ShowTransactionAttachments
+++ b/share/html/Elements/ShowTransactionAttachments
@@ -62,7 +62,7 @@ foreach my $message ( @{ $Attachments->{ $Parent || 0 } || [] } ) {
 % if (my $url = RT->System->ExternalStorageURLFor($message)) {
 <a href="<% $url %>">
 % } else {
-<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | u%>">
+<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name %>">
 % }
 <&|/l&>Download</&> <% length $name ? $name : loc('(untitled)') %></a>\
 % if ( $DownloadableHeaders && ! length $name && $message->ContentType =~ /text/  ) {

-----------------------------------------------------------------------