[Rt-commit] rt branch, 4.4/html-attachment-escaping, repushed

Rachel Kelly rachel at bestpractical.com
Fri May 13 16:04:02 EDT 2016


The branch 4.4/html-attachment-escaping was deleted and repushed:
       was 27d935639ac5507c891464770c96050151e27bd9
       now 503ce401c3a9b89bfbe97aa9a7c1b0a8421b6bee

1:  27d9356 ! 1:  503ce40 Remove url-escaping character from attachment name parsing
    @@ -3,8 +3,10 @@
         Remove url-escaping character from attachment name parsing
         
             Attachments in ticket replies and comments are parsed incorrectly
    -        if they contain an ampersand.  Removed url escaping in the
    -        displaying function of the attachment name.
    +        if they contain html characters.  Included url escaping and added
    +        requirement that no other escaping be done.  Attachment names
    +        which include ? and & and other url-sensitive characters will be
    +        preserved.
         
         Fixed: #I31751
     
    @@ -16,7 +18,7 @@
      <a href="<% $url %>">
      % } else {
     -<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | u%>">
    -+<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name %>">
    ++<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | un %>">
      % }
      <&|/l&>Download</&> <% length $name ? $name : loc('(untitled)') %></a>\
      % if ( $DownloadableHeaders && ! length $name && $message->ContentType =~ /text/  ) {



More information about the rt-commit mailing list