[Rt-commit] rt branch, 4.4/dashboard-subscription-user-group-fix, repushed

[Dustin Graves]

The branch 4.4/dashboard-subscription-user-group-fix was deleted and repushed:
       was c01791743f9d99b31d40e5d77f938c2824e69f16
       now bf6f1a259f8d1d387db092ae476e41669c09b33e

1:  c017917 ! 1:  b483a1c change dashboard subscription user loading to use RT->SystemUser and output any user load/create failure message
    @@ -1,24 +1,20 @@
     Author: Dustin Graves <dustin at bestpractical.com>
     
    -    add fix for dashboard subscription rights requirement and message in case of any failure
    -    remove setting of RealName field on user creation from dashboard subscription
    +    change dashboard subscription user loading to use RT->SystemUser and output any user load/create failure message
     
     diff --git a/share/html/Dashboards/Subscription.html b/share/html/Dashboards/Subscription.html
     --- a/share/html/Dashboards/Subscription.html
     +++ b/share/html/Dashboards/Subscription.html
     @@
    -             my @recipients = @{ $fields{Recipients}->{Users} };
    - 
                  for ( RT::EmailParser->ParseEmailAddress( $val ) ) {
    --                my ( $email, $name ) = ( $_->address, $_->name );
    -+                my $email = $_->address;
    +                 my ( $email, $name ) = ( $_->address, $_->name );
      
     -                my $user = RT::User->new($session{CurrentUser});
     -                $user->LoadOrCreateByEmail(
     +                my $user = RT::User->new(RT->SystemUser);
     +                ($ok, $msg) = $user->LoadOrCreateByEmail(
                          EmailAddress => $email,
    --                    RealName     => $name,
    +                     RealName     => $name,
                          Comments     => 'Autocreated when added as a dashboard subscription recipient',
                      );
      
    @@ -39,3 +35,4 @@
                  }
                  @{ $fields{Recipients}->{Users} } = uniq @recipients;
      
    +
-:  ------- > 2:  bf6f1a2 don't set RealName on dashboard subscription user creation