[Rt-commit] rt branch, 4.4/attachments-oracle, created. rt-4.4.0-228-g8768f1e

Shawn Moore shawn at bestpractical.com
Fri May 20 15:53:08 EDT 2016


The branch, 4.4/attachments-oracle has been created
        at  8768f1e58510ebfa742aa2c8d31a7ca29bf25bab (commit)

- Log -----------------------------------------------------------------
commit 8768f1e58510ebfa742aa2c8d31a7ca29bf25bab
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Thu May 19 16:34:51 2016 +0000

    Oracle needs a NULL check for attachment filename
    
        This fixes t/web/attach-from-txn.t on Oracle

diff --git a/share/html/Ticket/Elements/AddAttachments b/share/html/Ticket/Elements/AddAttachments
index 32c2c5e..64e46b1 100644
--- a/share/html/Ticket/Elements/AddAttachments
+++ b/share/html/Ticket/Elements/AddAttachments
@@ -199,6 +199,13 @@ if ($TicketObj && $TicketObj->id) {
         OPERATOR => '!=',
         VALUE    => '',
     );
+    $Existing->Limit(
+        FIELD           => 'Filename',
+        OPERATOR        => 'IS NOT',
+        VALUE           => 'NULL',
+        QUOTEVALUE      => 0,
+        ENTRYAGGREGATOR => 'AND',
+    );
     $HasExisting = 1 if $Existing->Count;
 }
 </%INIT>
diff --git a/share/html/Ticket/Elements/ShowAttachments b/share/html/Ticket/Elements/ShowAttachments
index ac663a9..1c9025d 100644
--- a/share/html/Ticket/Elements/ShowAttachments
+++ b/share/html/Ticket/Elements/ShowAttachments
@@ -137,6 +137,13 @@ $Attachments->Limit(
     OPERATOR => '!=',
     VALUE    => '',
 );
+$Attachments->Limit(
+    FIELD           => 'Filename',
+    OPERATOR        => 'IS NOT',
+    VALUE           => 'NULL',
+    QUOTEVALUE      => 0,
+    ENTRYAGGREGATOR => 'AND',
+);
 
 my $show_more = 0;
 my %documents;

-----------------------------------------------------------------------


More information about the rt-commit mailing list