[Rt-commit] rtir branch, 3.4/popup-ticket-create, repushed

[Dustin Graves]

The branch 3.4/popup-ticket-create was deleted and repushed:
       was 5a5cebc077c43e75375a01a0e468ff0c944922c8
       now be3bf5fac5a51f08eba5204865c2e69ff55cfd4b

 1:  debc038 =  1:  6622507 popup select queues for RTIR ticket create
 2:  aa24b8c =  2:  159ca21 remove "Create With Investigation" functionality
 3:  b4b0a1c =  3:  5aa66d1 skip RTIR ticket create modal if there's only one choice
 4:  73f9b63 =  4:  f3d58d1 fix incident child ticket creation
 5:  2a8b994 =  5:  37739af support constituency filtering with RTIR create in queue modal
 6:  873f43f =  6:  abe4b5d fix error and warnings in RT::Action::RTIR_ChangeChildConstituencies
 7:  e6f391a =  7:  16749c6 add support in the create RTIR queue modal for child linked tickets and enforce strict contituency linking throughout
 8:  767d065 =  8:  60e6f61 reordered CreateInRTIRQueueModal template to html/init/args convention
 9:  175f690 =  9:  7d53dce added documentation in UPGRADING-3.4 to reflect the removal of "Launch Investigation" on incident creation
10:  5e51506 = 10:  268b9e0 added tests for the new RTIR ticket create modal
11:  cd3f6b5 ! 11:  5aedc4e add js fallback ticket create page CreateInQueue
    @@ -11,7 +11,7 @@
     @@
              my $result .= qq{<a class="button" href="}. RT::IR->HREFTo("Tools/Lookup.html?".$args{lookup_params}."type=ip&q=".$escaped_host).qq{">}
                            .loc('Lookup IP') .q{</a>};
    -         if ( $args{incident} && !RT->Config->Get('RTIR_DisableBlocksQueue') ) {
    +         if ( $args{incident} && !RT->Config->Get('RTIR_DisableCountermeasures') ) {
     -            $result .= qq{<a class="button" href="} .
     -            RT::IR->HREFTo("Create.html?Incident=".$args{incident}."&Lifecycle=".RT::IR->lifecycle_countermeasure.qq{&IP-Value=$escaped_host})
     +            $result .= qq{<a class="button create_child_blocks" href="} .
    @@ -71,7 +71,7 @@
     -    path => RT::IR->HREFTo('Create.html?Lifecycle='.RT::IR->lifecycle_investigation, IncludeWebPath => 0),
     +    path => RT::IR->HREFTo('CreateInQueue.html?Lifecycle='.RT::IR->lifecycle_investigation, IncludeWebPath => 0),
      );
    - unless ( RT->Config->Get('RTIR_DisableBlocksQueue') ) {
    + unless ( RT->Config->Get('RTIR_DisableCountermeasures') ) {
          $root->child(
     @@
              path => RT::IR->HREFTo('Search/Results.html?Lifecycle='.RT::IR->lifecycle_countermeasure, IncludeWebPath => 0)
    @@ -252,7 +252,7 @@
                      Lifecycle => $Lifecycle,
                      Requestors => $q,
     @@
    -     } elsif ( $Lifecycle eq RT::IR->lifecycle_countermeasure && $LookupType eq 'ip' && !RT->Config->Get('RTIR_DisableBlocksQueue') ) {
    +     } elsif ( $Lifecycle eq RT::IR->lifecycle_countermeasure && $LookupType eq 'ip' && !RT->Config->Get('RTIR_DisableCountermeasures') ) {
              push @box_actions, {
                  title => loc('Create'),
     -            path => RT::IR->HREFTo("Create.html?". $m->comp('/Elements/QueryString',
12:  5a5cebc ! 12:  8e46d11 add create in queue pop-up (using js fallback) support to RTIR tests
    @@ -114,10 +114,10 @@
          is($agent->status, 200, "attempt to create succeeded");
      }
      
    --foreach ( 'Incidents', 'Incident Reports', 'Investigations', 'Blocks' ) {
    +-foreach ( 'Incidents', 'Incident Reports', 'Investigations', 'Countermeasures' ) {
     +# TODO: Once incident+investigation creation is re-added, this should be put back
    -+#foreach ( 'Incidents', 'Incident Reports', 'Investigations', 'Blocks' ) {
    -+foreach ( 'Incident Reports', 'Investigations', 'Blocks' ) {
    ++#foreach ( 'Incidents', 'Incident Reports', 'Investigations', 'Countermeasures' ) {
    ++foreach ( 'Incident Reports', 'Investigations', 'Countermeasures' ) {
          my $queue = RT::Queue->new(RT->SystemUser);
          $queue->Load( $_ );
          ok $agent->goto_create_ticket( $queue ), "UI -> create ticket";
    @@ -180,3 +180,4 @@
          is ($agent->status, 200, "Attempted to create the ticket");
          my $inv_id = ($agent->content =~ /.*Ticket (\d+) created.*/i )[0];
          ok ($inv_id, "Ticket created successfully: #$inv_id.");
    +
--:  ------- > 13:  be3bf5f  update new constituency tests for Blocks->Countermeasures change