[Rt-commit] rt branch, 4.6/inline-edit, updated. rt-4.4.1-143-g9b80306

[Shawn Moore]

The branch, 4.6/inline-edit has been updated
       via  9b803063aa7bb8959d00e804a9cd3301a7b6f43e (commit)
      from  440b2caf8a03b6b9ac3c2b0d254ed7395def19cb (commit)

Summary of changes:
 share/html/Elements/CollectionList | 18 ++++++++++--------
 share/html/Search/Bulk.html        |  3 ++-
 2 files changed, 12 insertions(+), 9 deletions(-)

- Log -----------------------------------------------------------------
commit 9b803063aa7bb8959d00e804a9cd3301a7b6f43e
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Fri Sep 16 16:59:30 2016 +0000

    Disable inline edit for bulk update
    
    Regardless of whether inline edit on bulk update even makes sense from a
    UI perspective, the entire bulk update page is contained in a <form>
    tag, and each inline edit widget uses its own <form> tag. This is
    problematic because HTML doesn't support nested forms. While this could
    be worked around by having inline edit reuse the form tag when possible
    and providing it when not, the additional complexity is not worth the
    (dubious) benefit.

diff --git a/share/html/Elements/CollectionList b/share/html/Elements/CollectionList
index 890e9e3..bbafd9b 100644
--- a/share/html/Elements/CollectionList
+++ b/share/html/Elements/CollectionList
@@ -164,14 +164,15 @@ while ( my $record = $Collection->Next ) {
     );
 
     $m->comp('/Elements/CollectionAsTable/Row',
-        i         => $i,
-        Format    => \@Format,
-        record    => $record,
-        maxitems  => $maxitems,
-        ColumnMap => $column_map,
-        Class     => $Class,
-        Warning   => $warning,
-        Classes   => $Classes,
+        i          => $i,
+        Format     => \@Format,
+        record     => $record,
+        maxitems   => $maxitems,
+        ColumnMap  => $column_map,
+        Class      => $Class,
+        Warning    => $warning,
+        Classes    => $Classes,
+        InlineEdit => $InlineEdit,
     );
 
     $$HasResults++ if $HasResults;
@@ -219,6 +220,7 @@ $ShowNavigation => 1
 $ShowHeader     => 1
 $ShowCols       => 1
 $ShowEmpty      => 0
+$InlineEdit     => RT->Config->Get('InlineEdit', $session{CurrentUser})
 $Query => 0
 $HasResults     => undef
 </%ARGS>
diff --git a/share/html/Search/Bulk.html b/share/html/Search/Bulk.html
index 9e193a5..bb436a3 100644
--- a/share/html/Search/Bulk.html
+++ b/share/html/Search/Bulk.html
@@ -63,7 +63,8 @@
     Rows => $Rows,
     Page => $Page,
     BaseURL => RT->Config->Get('WebPath')."/Search/Bulk.html?",
-    Class => 'RT::Tickets'
+    Class => 'RT::Tickets',
+    InlineEdit => 0,
    &>
 
 % $m->callback(CallbackName => 'AfterTicketList', ARGSRef => \%ARGS);

-----------------------------------------------------------------------