[Rt-commit] rt branch, 4.4/improve-add-custom-role-message, created. rt-4.4.2-38-g71131b0

[Maureen Mirville]

The branch, 4.4/improve-add-custom-role-message has been created
        at  71131b006948cce1d5278751fb1008bd124c7881 (commit)

- Log -----------------------------------------------------------------
commit 71131b006948cce1d5278751fb1008bd124c7881
Author: Maureen E. Mirville <maureen at bestpractical.com>
Date:   Wed Aug 30 10:46:17 2017 -0400

    Improve message when adding/removing custom roles from queues
    
    When user is adding or removing a custom role from a queue, previous
    message after making a change, "Object created" or "Object deleted"
    was unclear. Message updated to make it clear user added a role or
    removed a role from a queue.
    
    Fixes: I#32695

diff --git a/share/html/Admin/CustomRoles/Objects.html b/share/html/Admin/CustomRoles/Objects.html
index 5f11a26..0e41690 100644
--- a/share/html/Admin/CustomRoles/Objects.html
+++ b/share/html/Admin/CustomRoles/Objects.html
@@ -111,13 +111,15 @@ if ( $Update ) {
     if ( defined (my $del = $ARGS{"RemoveRole-$id"}) ) {
         foreach my $id ( ref $del ? (@$del) : ($del) ) {
             my ($status, $msg) = $role->RemoveFromObject( $id );
-            push @results, $msg;
+            my $role_name = $role->Name;
+            push @results, "$role_name removed from queue #$id";
         }
     }
     if ( defined (my $add = $ARGS{"AddRole-$id"}) ) {
         foreach my $id ( ref $add ? (@$add) : ($add) ) {
             my ($status, $msg) = $role->AddToObject( $id );
-            push @results, $msg;
+            my $role_name = $role->Name;
+            push @results, "$role_name added to queue #$id";
         }
     }
     MaybeRedirectForResults(

-----------------------------------------------------------------------