[Rt-commit] rt branch, 4.4/untake-action, updated. rt-4.4.1rc2-2-g480bc73

Craig Kaiser craig at bestpractical.com
Tue Dec 5 13:22:47 EST 2017


The branch, 4.4/untake-action has been updated
       via  480bc73728376f857117ff87483c02661505d459 (commit)
      from  12a56ac6ae78c1d920b465dd2ae0f99359549de7 (commit)

Summary of changes:
 share/html/Elements/Tabs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 480bc73728376f857117ff87483c02661505d459
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Tue Dec 5 13:21:20 2017 -0500

     Clean up code, make more readable and remove redundant line

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index 8696e11..bbf0e5a 100644
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -777,7 +777,7 @@ my $build_main_nav = sub {
                     my $key = $info->{'label'} || ucfirst($next);
                     $actions->child( $key => title => loc( $key ), path => $url);
                 }
-                my ($can_untake, $umsg) = $obj->CurrentUserCanSetOwner( );
+                my ($can_untake, $umsg) = $obj->CurrentUserCanSetOwner( Type => 'Untake' );
                 my ($can_take, $tmsg) = $obj->CurrentUserCanSetOwner( Type => 'Take' );
                 my ($can_steal, $smsg) = $obj->CurrentUserCanSetOwner( Type => 'Steal' );
                 if ( $can_take ){
@@ -785,7 +785,6 @@ my $build_main_nav = sub {
                 }
                 elsif ( $can_steal ){
                     $actions->child( steal => title => loc('Steal'), path => "/Ticket/Display.html?Action=Steal;id=" . $id );
-                    my ($can_untake, $umsg) = $obj->CurrentUserCanSetOwner( );
                 }elsif ( $can_untake ){
                        $actions->child( untake => title => loc('Untake'), path => "/Ticket/Display.html?Action=Untake;id=" . $id );
                 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list