[Rt-commit] rt branch, 4.4/untake-action, repushed

Craig Kaiser craig at bestpractical.com
Tue Dec 5 15:29:29 EST 2017


The branch 4.4/untake-action was deleted and repushed:
       was 480bc73728376f857117ff87483c02661505d459
       now 31c07e79d8ea61c5ea0226539733388a059710d9

1:  12a56ac ! 1:  31c07e7 Add Untake action to actions tab on Ticket
    @@ -1,6 +1,9 @@
     Author: Craig Kaiser <craig at bestpractical.com>
     
         Add Untake action to actions tab on Ticket
    +    
    +     where owner can Untake and set owner
    +     to nobody
     
     diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
     --- a/share/html/Elements/Tabs
    @@ -10,7 +13,7 @@
                          $actions->child( $key => title => loc( $key ), path => $url);
                      }
     -
    -+                my ($can_untake, $umsg) = $obj->CurrentUserCanSetOwner( );
    ++                my ($can_untake, $umsg) = $obj->CurrentUserCanSetOwner( Type => 'Untake' );
                      my ($can_take, $tmsg) = $obj->CurrentUserCanSetOwner( Type => 'Take' );
                      my ($can_steal, $smsg) = $obj->CurrentUserCanSetOwner( Type => 'Steal' );
                      if ( $can_take ){
    @@ -18,7 +21,6 @@
                      }
                      elsif ( $can_steal ){
                          $actions->child( steal => title => loc('Steal'), path => "/Ticket/Display.html?Action=Steal;id=" . $id );
    -+                    my ($can_untake, $umsg) = $obj->CurrentUserCanSetOwner( );
     +                }elsif ( $can_untake ){
     +                       $actions->child( untake => title => loc('Untake'), path => "/Ticket/Display.html?Action=Untake;id=" . $id );
                      }
    @@ -37,4 +39,3 @@
                      my $action = $1;
                      my ($res, $msg) = $TicketObj->$action();
                      push(@Actions, $msg);
    -
2:  480bc73 < -:  -------  Clean up code, make more readable and remove redundant line



More information about the rt-commit mailing list