[Rt-commit] rt branch, 4.4-trunk, updated. rt-4.4.1-242-gb2e1200

[Shawn Moore]

The branch, 4.4-trunk has been updated
       via  b2e120087d1da005449da24d174a0d75b9f5a541 (commit)
       via  cd9bb5215bf935dd53db1b3023d0ee033af0110c (commit)
      from  f94065596171b365c10d911bdbd489953932f8f6 (commit)

Summary of changes:
 lib/RT/Config.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit cd9bb5215bf935dd53db1b3023d0ee033af0110c
Author: Dustin Collins <strega at bestpractical.com>
Date:   Sat Dec 31 18:45:21 2016 -0500

    Fix ExternalAuth failure after viewing System Configuration
    
    ExternalSettings's Obfuscate callback was inadvertently overwriting the
    password in RT's configuration with "Password not printed", so after
    viewing the System Configuration page, any use of ExternalAuth in that
    process would fail due to having the incorrect password.
    
    This solution avoids the problem with ExternalSettings specifically, but
    also any similar issues we may have elsewhere now and in the future, by
    cloning the config data structure before passing it to Obfuscate. That
    way any kind of obfuscation is limited in scope to just the System
    Configuration page.
    
    Fixes: I#32469

diff --git a/lib/RT/Config.pm b/lib/RT/Config.pm
index 737aa0b..d3febc9 100644
--- a/lib/RT/Config.pm
+++ b/lib/RT/Config.pm
@@ -55,6 +55,7 @@ use 5.010;
 use File::Spec ();
 use Symbol::Global::Name;
 use List::MoreUtils 'uniq';
+use Storable ();
 
 =head1 NAME
 
@@ -1491,7 +1492,7 @@ sub GetObfuscated {
 
     return $self->Get(@_) unless $obfuscate;
 
-    my $res = $self->Get(@_);
+    my $res = Storable::dclone($self->Get(@_));
     $res = $obfuscate->( $self, $res, $user );
     return $self->_ReturnValue( $res, $META{$name}->{'Type'} || 'SCALAR' );
 }

commit b2e120087d1da005449da24d174a0d75b9f5a541
Merge: f940655 cd9bb52
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Jan 11 18:15:14 2017 +0000

    Merge branch '4.4/sys-config-blocks-externalauth' into 4.4-trunk


-----------------------------------------------------------------------