[Rt-commit] rt branch, 4.4/attachtickets-mail, created. rt-4.4.1-1-g04e6235

[Shawn Moore]

The branch, 4.4/attachtickets-mail has been created
        at  04e6235455aa4420997825cde02c4e1a6354bba5 (commit)

- Log -----------------------------------------------------------------
commit 04e6235455aa4420997825cde02c4e1a6354bba5
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Tue Jan 31 18:58:41 2017 +0000

    Don't skip sending mail if there are attached tickets
    
    Ordinarily RT will skip processing an update message (and therefore not
    send mail about a comment or correspondence) if the message is empty and
    there are no upload attachments. This means we can say the intent of
    this code is to allow empty message with just attachments. However, the
    code didn't cover the case of attaching tickets instead of files.
    
    This attaching tickets feature is primarily used in RTIR to attach IRs
    to mail about an incident.
    
    Fixes: T#180155

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index e3cf905..d4a9bfb 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -2341,6 +2341,7 @@ sub ProcessUpdateMessage {
     # UpdateTimeWorked into adjusted TimeWorked, so that a later
     # ProcessBasics can deal -- then bail out.
     if (    not @attachments
+        and not $args{ARGSRef}->{'AttachTickets'}
         and not length $args{ARGSRef}->{'UpdateContent'} )
     {
         if ( $args{ARGSRef}->{'UpdateTimeWorked'} ) {

-----------------------------------------------------------------------