[Rt-commit] rt branch, 4.4/role-group-input, repushed

[Shawn Moore]

The branch 4.4/role-group-input was deleted and repushed:
       was a74de15605f7a71751289bcfe502f492a862d854
       now 44393ea4a186537b2b349b76fa99a6dffa16d1ff

1:  1938011 ! 1:  7420761 Reuse CanonicalizePrincipal in DeleteRoleMember
    @@ -67,7 +67,7 @@
              unless $group->HasMember($principal);
      
     -    my ($ok, $msg) = $group->_DeleteMember($args{PrincipalId}, RecordTransaction => !$args{Silent});
    -+    my ($ok, $msg) = $group->_DeleteMember($principal->Id, RecordTransaction => !$args{Silent});
    ++    ((my $ok), $msg) = $group->_DeleteMember($principal->Id, RecordTransaction => !$args{Silent});
          unless ($ok) {
     -        $RT::Logger->error("Failed to remove $args{PrincipalId} as a member of group ".$group->Id.": ".$msg);
     +        $RT::Logger->error("Failed to remove ".$principal->Id." as a member of group ".$group->Id.": ".$msg);
2:  cff80a9 ! 2:  a9b067a Handle Group:Name and Group:ID in role input fields
    @@ -20,7 +20,7 @@
              }
          } else {
     -        if ($args{User}) {
    -+        if ($args{User} =~ /^\s*Group\s*:\s*(.+?)\s*$/) {
    ++        if (($args{User}||'') =~ /^\s*Group\s*:\s*(.+?)\s*$/) {
     +            $args{Group} = $1;
     +            delete $args{User};
     +        }
3:  3e0bced = 3:  ab2a019 Autocompleter for Principals (users and groups)
4:  a74de15 = 4:  44393ea Switch to Principals autocompleter for role input fields